Skip to content

Send the generic-key subList request with the generic key #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobHofmann merged 1 commit into from
Sep 24, 2026
Merged

Send the generic-key subList request with the generic key #527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions custom_components/gree/gree_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,8 +726,10 @@ async def get_subunits_list(mac_addr, ip_addr, port):
* Device-key form (``i:0`` / ``t:"pack"``): the response is encrypted with
the gateway's *bound* device key. This is what GR-Gcloud V3.2.M answers.
* Generic-key form (``i:1`` / ``t:"subList"``, the classic app form): the
response is encrypted with the *generic* key (like scan/bind). Some
modules only answer this form.
response is encrypted with the *generic* key (like scan/bind), so the
request uses the generic key too. GR-Gcloud V3.2.M ignores the request
pack of this form: device, generic and random keys all got the same
answer (PR 507). Some modules only answer this form.

On v1 we query *both* forms and union the results by MAC: different
firmwares answer different forms, and some gateways return a slightly
Expand Down Expand Up @@ -769,9 +771,9 @@ async def get_subunits_list(mac_addr, ip_addr, port):
payload = f'{{"cid":"app","i":0,"pack":"{pack}","t":"pack","tcid":"{mac_addr}","uid":0}}'
device_units = await _subunits_send_ecb(ip_addr, port, payload, device_key)

# Generic-key form: i:1 / t:subList -> response encrypted with generic key.
# Generic-key form: i:1 / t:subList -> request and response use the generic key.
inner_fb = f'{{"mac":"{mac_addr}","i":1}}'
pack_fb = base64.b64encode(AES.new(device_key, AES.MODE_ECB).encrypt(Pad(inner_fb).encode("utf8"))).decode("utf-8")
pack_fb = base64.b64encode(AES.new(generic_key, AES.MODE_ECB).encrypt(Pad(inner_fb).encode("utf8"))).decode("utf-8")
payload_fb = f'{{"cid":"app","i":1,"pack":"{pack_fb}","t":"subList","tcid":"{mac_addr}","uid":0}}'
generic_units = await _subunits_send_ecb(ip_addr, port, payload_fb, generic_key)

Expand Down