Only hold commanded values for VRF sub-units - #525
Merged
Merged
Conversation
#508 re-applies the commanded values over the read-back for up to 8 s, so a VRF gateway's stale cache does not revert the UI. It did that for every unit. A standalone unit is read directly, and when it corrects a value it cannot take (for example an unsupported swing mode), it reports its own value. The hold then kept the refused value on screen for up to 8 s, where before the UI showed the corrected value at once. The hold and the 2 s follow-up read now only apply when the device is a sub-unit (sub MAC differs from the gateway MAC). Standalone units behave as before #508. The same change went into the 5.0 port (#522).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#508 (4.0.7) holds commanded values over the read-back for up to 8 s, so a VRF gateway's stale cache does not revert the UI. It does that for every unit, also for standalone units, which have no gateway cache.
That has a cost there, raised by @p-monteiro. When a standalone unit gets a value it cannot take, for example a swing mode it does not support, it corrects itself and reports a valid value. With the hold, the UI kept showing the refused value for up to 8 s. Before #508 it showed the corrected value at once.
Change
The hold and the 2 s follow-up read now only apply when the device is a VRF sub-unit, that is when the sub MAC differs from the gateway MAC. Standalone units behave as they did before #508: no hold, no extra poll per command.
The same change is in the 5.0 port, #522.
Testing
My fake-device harness drives the real
climate.py. 39/39 checks passed: