Repository navigation
Conversation
shyamenk
force-pushed
the
feat/devops-syntaxes
branch
2 times, most recently
from
November 10, 2026 05:23
1e5449e to
513fb95
Compare
Switch to the two-face syntax bundle so Terraform/HCL, TOML, INI, Groovy, Dockerfile, Makefile, Rego, Protocol Buffers and nginx files get syntax highlighting. Add aliases for Jinja2 and Helm templates (tpl, gotmpl), systemd units, Ansible inventory, Tiltfile and Vagrantfile. Kubernetes manifests and Ansible playbooks are YAML. Add a syntax_key helper so extensionless files (Dockerfile, Makefile, Jenkinsfile, .env, ...) are recognized when opened, and let `extras` match file names so they appear in the file pickers.
shyamenk
force-pushed
the
feat/devops-syntaxes
branch
from
November 10, 2026 06:53
513fb95 to
7f2339f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
two-facebundle (the extra syntaxesbatships). It uses the same syntect 5.2 / onig backend, so no new regex engine.tf,tfvars,hcl,terraform,make/makefile,env/ini/conf, andgroovy/jenkinsfile.syntax_keyhelper so extensionless files (Dockerfile,Dockerfile.*,Makefile,Jenkinsfile,.env) are highlighted when opened and are accepted by the file picker when their file name (e.g.Dockerfile) is listed inextras.values.yamland playbooks are YAML and were already covered. Added Jinja2 (j2), Helm templates (tpl,gotmpl, highlighted as Jinja2 since no Go-template grammar ships), Rego, Protocol Buffers, systemd units and Ansibleinventory(as INI), nginxconf, andTiltfile/Vagrantfile.Why
Terraform/HCL, Dockerfile and Makefile files opened as plain Markdown with no highlighting (
.tfalso got its straight quotes converted to curly ones), because the default syntect set has no HCL grammar and Leaf only looked at file extensions.How it was tested
cargo test: 983 passed, including newresolve_syntax_supports_devops_file_typesandsyntax_key_maps_extensionless_devops_files. The shared test syntax set now uses two-face too.cargo clippy --all-targets --all-features -- -D warningsandcargo fmt --check: clean.leaf --inline ansion sample files, counting distinct colors before/after:main.tf1 → 6,Dockerfile1 → 4,Makefile1 → 4, YAML unchanged.--picker) and fuzzy picker (--fuzzy) listDockerfile/Makefilewhen named inextras, andleaf Dockerfileopens highlighted. New testfile_picker_lists_extensionless_devops_files_from_extras.cargo build --releaseon the same machine (upstreammainat 554dcea vs this branch):leaf --inline plain README.md, 200 interleaved runs each): median 4.79 ms -> 6.58 ms (+1.79 ms), p95 5.21 ms -> 7.33 ms. The extra time is the larger syntax set being loaded at launch.