fix(release): don't treat changelog edits as a reason to ship#9
Merged
Conversation
CHANGELOG.md lives inside an artifact's own paths, so a changelog-only commit that isn't a release commit reads as a source change. Restoring the eroded changelog history did exactly that: the next dry-run offered to publish a new @reprojs/core to npm, rebuild the dashboard image, and push the extension into public Web Store review — with no code change behind any of it. Exclude *CHANGELOG.md from detection. It's a release artifact, not source; editing one is never a reason to ship a package. This can't hide real work — no source lives in a CHANGELOG — and it's independent of the existing release-commit exclusion, which covers the version bump in package.json. Caught by --dry-run before it published anything. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdlives inside an artifact's own paths, so a changelog-only commit that isn't a release commit reads as a source change.Restoring the eroded changelog history (#8) did exactly that. The very next dry-run offered to:
— publish a new SDK to npm (immutable 72h), rebuild the image, and push the extension into public Web Store review, with no code change behind any of it.
--dry-runcaught it before anything shipped.Fix
Exclude
*CHANGELOG.mdfrom affected-detection. It's a release artifact, not source; editing one is never a reason to ship a package.This can't hide real work — no source lives in a CHANGELOG — and it's independent of the existing release-commit exclusion, which covers the version bump in
package.json. The two together mean nothing a release itself writes can make the next release look necessary.Verification
Both directions, in a throwaway clone on
main:packages/uichangeThe second matters most: it proves the exclusion narrowed the false positive without blinding detection to genuine work.
🤖 Generated with Claude Code