feat(config): display Tor hidden address and status#109
Open
64johnlee wants to merge 21 commits into
Open
Conversation
- Add displayHiddenStatus component showing hidden mode (Enabled/Disabled) - Add displayHiddenAddress component showing hiddenNodeAddress and hiddenPort - Both components use details from /rsPeers/getPeerDetails API - Integrated into Network Configuration grid in config_network.js - Also updated config_node.js Public Information to show hidden address/port Fixes issue RetroShare#88 - Tor Status not works and hidden address display in settings is missed
Contributor
|
but this is not clean,
|
Author
|
Hi @defnax, I've cleaned up the branch. The 24
Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue #88 - Tor Status not works and hidden address display in settings is missed.
Changes
config_network.js: AddeddisplayHiddenStatuscomponent showing hidden mode (Enabled/Disabled)config_network.js: AddeddisplayHiddenAddresscomponent showing hiddenNodeAddress and hiddenPortconfig_node.js: Updated Public Information to also display hidden address/port when enabled/rsPeers/getPeerDetailsAPI which providesisHiddenNode,hiddenNodeAddress,hiddenPortfieldsFiles changed
Testing