lr-hatari: fix core build due to upstream changes - #4228
Open
cmitu wants to merge 2 commits into
Open
Conversation
Upstream started incorporating the latest Hatari version into the core and renamed the previouos core version to `hatari2014`. Until the merge is complete and stable, use the old version, now in a separate branch. Modified the build to: - use the CAPSIMG variables that are now part of the upstream `makefile`, instead of using our own - update our patch to exclude our link/include flags for CAPSIMG in the `makefile` and fix the core name - use `-rpath` linker option to have the core `.so` library search for the `campsimg` library in the install folder (similar to how the standalone emulator build recipe does). This alows us to get rid of the `configure` modifications to `emulators.cfg` for setting `LD_LIBRARY_PATH`
cmitu
marked this pull request as draft
September 6, 2026 17:19
Contributor
Author
|
I've set the PR to draft for now, since our patch may have to be modified again, pending some upstream changes. |
Upstream started incorporating the latest Hatari version into the core and renamed the previouos core version to `hatari2014`. Until the merge is complete and stable, use the old version, now in a separate branch. Modified the build to: - use the CAPSIMG variables that are now part of the upstream `makefile`, instead of using our own (C|LD)FLAGS - remove our patch since upstream added similar changes to the source to solve the type conflict that caused build issues and the makefile changes are no longer needed - make the core name configurable by modifying the `makefile`'s _TARGET_NAME_ variable, so it can be changes at build time. - use `-rpath` linker option to have the core `.so` library search for the `campsimg` library in the install folder (similar to how the standalone emulator build recipe does). This alows us to get rid of the `configure` modifications to `emulators.cfg` for setting `LD_LIBRARY_PATH`
cmitu
force-pushed
the
lr-hatari-2014
branch
from
September 7, 2026 04:19
0e0e6ce to
596b024
Compare
cmitu
marked this pull request as ready for review
September 7, 2026 04:19
Contributor
Author
|
OK, reworked the patch, taking into account latest libretro branch changes, and removed our patch entirely. Edited the PR's description to match the commit changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream started incorporating the latest Hatari version into the core and renamed the previouos core version to
hatari2014. Until the merge is complete and stable, use the old version, now in a separate branch.Modified the build to:
makefile, instead of using our ownmakefileand fix the core name-rpathlinker option to have the core.solibrary search for thecampsimglibrary in the install folder (similar to how the standalone emulator build recipe does). This alows us to get rid of theconfiguremodifications toemulators.cfgfor settingLD_LIBRARY_PATHNotes:
lr-hatari2014.hatariwhen creating the 2014 branch.