skyscraper: update the system/platform detection - #4224
Open
Gemba wants to merge 1 commit into
Open
Conversation
Do rely on configured systems in EmulationStation config instead of platform discovery in `~/RetroPie/roms/` because the latter may contain extra directories which do not qualify as recognized platform.
Gemba
force-pushed
the
skyscraper_update_systemlisting
branch
from
September 2, 2026 19:03
fcca79b to
09f26cf
Compare
Contributor
|
I think the current behavior is good enough and has the advantage of listing only the populated folders. For instance, on my system I have only 44 populated ROM folders, while ES has 58 configured, and the difference would be bigger on a new RP system when more emulators/platforms would be available in ES vs. what would be populated by the user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do rely on configured systems in EmulationStation config instead of platform discovery in
~/RetroPie/roms/because the latter may contain extra directories which do not qualify as valid platform.