Skip to content

Fix mis-named .dll in OpenVisualStudio csproj file.#1284

Merged
Arctis-Fireblight merged 1 commit into
Redot-Engine:masterfrom
GeneralProtectionFault:openvisualstudio_fix
Jun 27, 2026
Merged

Fix mis-named .dll in OpenVisualStudio csproj file.#1284
Arctis-Fireblight merged 1 commit into
Redot-Engine:masterfrom
GeneralProtectionFault:openvisualstudio_fix

Conversation

@GeneralProtectionFault

@GeneralProtectionFault GeneralProtectionFault commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Fixes #1155

Tested by building on Linux (mingw, etc...):

./modules/mono/build_scripts/build_assemblies.py --godot-output-dir=./bin --godot-platform=windows

This command created the RedotTools.OpenVisualStudio.dll & similar files in the resulting GodotSharp/Tools folder after fixing the .dll name. This should fix the missing functionality for Windows users if integrated into the CI pipeline.

Summary by CodeRabbit

  • Bug Fixes
    • Improved Windows build configuration to correctly detect the updated debug DLL, helping the editor integrate with the right runtime files.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The OpenVisualStudio project condition now checks for RedotSharp.dll instead of GodotSharp.dll on Windows debug builds.

Changes

OpenVisualStudio project condition update

Layer / File(s) Summary
Debug DLL condition swap
modules/mono/editor/GodotTools/GodotTools.OpenVisualStudio/RedotTools.OpenVisualStudio.csproj
The Windows debug PropertyGroup condition now references RedotSharp.dll at the existing $(SolutionDir)/../../../../bin/GodotSharp/Api/Debug/ path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: correcting a misnamed DLL reference in the OpenVisualStudio csproj.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Arctis-Fireblight Arctis-Fireblight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I totally missed this in the rebranding!
Approved.

@Arctis-Fireblight Arctis-Fireblight merged commit f7c88fc into Redot-Engine:master Jun 27, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual Studio in not opening

2 participants