Skip to content

Update release build scripts to enable DX12 support on Windows#1279

Merged
Arctis-Fireblight merged 1 commit into
Redot-Engine:masterfrom
Arctis-Fireblight:fix-dx12-support
Jun 22, 2026
Merged

Update release build scripts to enable DX12 support on Windows#1279
Arctis-Fireblight merged 1 commit into
Redot-Engine:masterfrom
Arctis-Fireblight:fix-dx12-support

Conversation

@Arctis-Fireblight

@Arctis-Fireblight Arctis-Fireblight commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Adjusted release build scripts to install dx12 dependencies, and added the build flags to enable DX12 support for Windows builds.

Summary by CodeRabbit

  • Chores
    • Updated Windows build configuration to enable D3D12 graphics API support, including automatic installation of the required D3D12 SDK as part of the build setup.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dbe47471-3c21-4697-bc4b-5452ef0d7288

📥 Commits

Reviewing files that changed from the base of the PR and between 47c2d69 and 7ab81cb.

📒 Files selected for processing (1)
  • .gitlab-ci.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .gitlab-ci.yml

Walkthrough

Four Windows CI template jobs in .gitlab-ci.yml are updated to run install_d3d12_sdk_windows.py in before_script and extend OPTIONS with d3d12=yes. The change is applied uniformly to the Windows editor, Windows Mono, Windows release-template, and Windows Mono release-template jobs.

Changes

D3D12 Support in Windows CI Templates

Layer / File(s) Summary
D3D12 SDK install and flag across all Windows template jobs
.gitlab-ci.yml
All four Windows template before_script blocks now invoke install_d3d12_sdk_windows.py and set d3d12=yes in OPTIONS, covering Windows editor, Windows Mono, Windows release-template, and Windows Mono release-template variants.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating build scripts to enable DX12/D3D12 support on Windows, which matches the changeset modifications to .gitlab-ci.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.gitlab-ci.yml:
- Line 130: The export OPTIONS variable uses the incorrect SCons option name
D3D12_ENABLED=yes, but the SConstruct file declares the option as d3d12, causing
the build system to silently ignore it and leave D3D12 disabled. Replace all
instances of D3D12_ENABLED=yes with d3d12=yes in the OPTIONS variable on lines
130, 142, 154, and 183 to ensure the Direct3D 12 rendering driver is properly
enabled during the build process.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3c0aa6e3-0f8c-4d00-9d4a-ae3ee2b7738f

📥 Commits

Reviewing files that changed from the base of the PR and between 52b3310 and 47c2d69.

📒 Files selected for processing (1)
  • .gitlab-ci.yml

Comment thread .gitlab-ci.yml Outdated
@Arctis-Fireblight Arctis-Fireblight merged commit 6499044 into Redot-Engine:master Jun 22, 2026
17 checks passed
@Arctis-Fireblight Arctis-Fireblight deleted the fix-dx12-support branch June 22, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant