Update release build scripts to enable DX12 support on Windows#1279
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughFour Windows CI template jobs in ChangesD3D12 Support in Windows CI Templates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.gitlab-ci.yml:
- Line 130: The export OPTIONS variable uses the incorrect SCons option name
D3D12_ENABLED=yes, but the SConstruct file declares the option as d3d12, causing
the build system to silently ignore it and leave D3D12 disabled. Replace all
instances of D3D12_ENABLED=yes with d3d12=yes in the OPTIONS variable on lines
130, 142, 154, and 183 to ensure the Direct3D 12 rendering driver is properly
enabled during the build process.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3c0aa6e3-0f8c-4d00-9d4a-ae3ee2b7738f
📒 Files selected for processing (1)
.gitlab-ci.yml
47c2d69 to
7ab81cb
Compare
Adjusted release build scripts to install dx12 dependencies, and added the build flags to enable DX12 support for Windows builds.
Summary by CodeRabbit