Skip to content

Rename structs (members), files, directories.#37

Open
OldDev78 wants to merge 18 commits into
Redot-Engine:masterfrom
OldDev78:renaming-consistency
Open

Rename structs (members), files, directories.#37
OldDev78 wants to merge 18 commits into
Redot-Engine:masterfrom
OldDev78:renaming-consistency

Conversation

@OldDev78

@OldDev78 OldDev78 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Filesystem structure renamed to use PascalCase - with a few exceptions with third party libraries and low-level C code.
Classes, structs use PascalCase. Member and free functions use camelCase. Namespaces and module names (in code) remain lower case, following C++ best practices.

Imports/includes have been cleaned up.

A few places in Rendering and RenderSample with excessive memcopying have been simplified.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 153 files, which is 3 over the limit of 150.

To get a review, narrow the scope:
• coderabbit review --type committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 119f61b9-5840-424b-b18a-5e34216d5b62

📥 Commits

Reviewing files that changed from the base of the PR and between 4b1ebc5 and f8f5933.

⛔ Files ignored due to path filters (3)
  • Engine/cpp/ThirdParty/cmake/bgfx/generated/bounds.cpp.in is excluded by !**/generated/**
  • Engine/cpp/ThirdParty/cmake/bgfx/generated/shader.cpp.in is excluded by !**/generated/**
  • Engine/cpp/ThirdParty/cmake/bgfx/generated/vertexlayout.cpp.in is excluded by !**/generated/**
📒 Files selected for processing (153)
  • .gitmodules
  • Engine/cpp/CMakeLists.txt
  • Engine/cpp/Runtime/CMakeLists.txt
  • Engine/cpp/Runtime/Core/CMakeLists.txt
  • Engine/cpp/Runtime/Core/Core.cppm
  • Engine/cpp/Runtime/Core/Definitions/Definitions.cppm
  • Engine/cpp/Runtime/Core/Definitions/StdTypes.cppm
  • Engine/cpp/Runtime/Core/IO/FileSystem.cpp
  • Engine/cpp/Runtime/Core/IO/FileSystem.cppm
  • Engine/cpp/Runtime/Core/IO/IO.cppm
  • Engine/cpp/Runtime/Core/IO/ImageLoader.cpp
  • Engine/cpp/Runtime/Core/IO/ImageLoader.cppm
  • Engine/cpp/Runtime/Core/Math/Constants.cppm
  • Engine/cpp/Runtime/Core/Math/Functions.cppm
  • Engine/cpp/Runtime/Core/Math/Math.cppm
  • Engine/cpp/Runtime/Core/Math/Math.test.cpp
  • Engine/cpp/Runtime/Core/Math/Transform.cpp
  • Engine/cpp/Runtime/Core/Math/Transform.cppm
  • Engine/cpp/Runtime/Core/Math/Types.cppm
  • Engine/cpp/Runtime/Core/Math/TypesCommon.cppm
  • Engine/cpp/Runtime/Core/Math/Vector2.cppm
  • Engine/cpp/Runtime/Core/Math/Vector3.cppm
  • Engine/cpp/Runtime/Core/Math/Vector4.cppm
  • Engine/cpp/Runtime/Core/Memory/Allocator.cpp
  • Engine/cpp/Runtime/Core/Memory/Allocator.cppm
  • Engine/cpp/Runtime/Core/Memory/BumpAllocator.cpp
  • Engine/cpp/Runtime/Core/Memory/BumpAllocator.cppm
  • Engine/cpp/Runtime/Core/Memory/BumpAllocator.test.cpp
  • Engine/cpp/Runtime/Core/Memory/FixedAllocator.cpp
  • Engine/cpp/Runtime/Core/Memory/FixedAllocator.cppm
  • Engine/cpp/Runtime/Core/Memory/FixedAllocator.test.cpp
  • Engine/cpp/Runtime/Core/Memory/Handle.cppm
  • Engine/cpp/Runtime/Core/Memory/HandleRegistry.cppm
  • Engine/cpp/Runtime/Core/Memory/Memory.cppm
  • Engine/cpp/Runtime/Core/Memory/PageAllocator.cpp
  • Engine/cpp/Runtime/Core/Memory/PageAllocator.cppm
  • Engine/cpp/Runtime/Core/Memory/Slice.cppm
  • Engine/cpp/Runtime/Core/Memory/SlotArray.cppm
  • Engine/cpp/Runtime/Core/Memory/TrackingAllocator.cpp
  • Engine/cpp/Runtime/Core/Memory/TrackingAllocator.cppm
  • Engine/cpp/Runtime/Core/Memory/TrackingAllocator.test.cpp
  • Engine/cpp/Runtime/Core/Version.cppm
  • Engine/cpp/Runtime/Draconic.cppm
  • Engine/cpp/Runtime/Input/Input.cpp
  • Engine/cpp/Runtime/Input/Input.cppm
  • Engine/cpp/Runtime/Platform/CMakeLists.txt
  • Engine/cpp/Runtime/Platform/Platform.cppm
  • Engine/cpp/Runtime/Platform/cpu/cpu_info.h
  • Engine/cpp/Runtime/Platform/cpu/cpu_info_neon.cpp
  • Engine/cpp/Runtime/Platform/cpu/cpu_info_x64.cpp
  • Engine/cpp/Runtime/Platform/impl/CMakeLists.txt
  • Engine/cpp/Runtime/Platform/impl/linux/linux.cpp
  • Engine/cpp/Runtime/Platform/impl/mac/mac.mm
  • Engine/cpp/Runtime/Platform/impl/platform_impl.h
  • Engine/cpp/Runtime/Platform/impl/win32/win32.cpp
  • Engine/cpp/Runtime/Platform/simd.h
  • Engine/cpp/Runtime/Rendering/CMakeLists.txt
  • Engine/cpp/Runtime/Rendering/Material/Material.cppm
  • Engine/cpp/Runtime/Rendering/Mesh/Mesh.cpp
  • Engine/cpp/Runtime/Rendering/Mesh/Mesh.cppm
  • Engine/cpp/Runtime/Rendering/QuadRenderer/QuadRenderer.cpp
  • Engine/cpp/Runtime/Rendering/QuadRenderer/QuadRenderer.cppm
  • Engine/cpp/Runtime/Rendering/RHI/Buffers.cpp
  • Engine/cpp/Runtime/Rendering/RHI/Commands.cpp
  • Engine/cpp/Runtime/Rendering/RHI/Core.cpp
  • Engine/cpp/Runtime/Rendering/RHI/Pipelines.cpp
  • Engine/cpp/Runtime/Rendering/RHI/RHI.cppm
  • Engine/cpp/Runtime/Rendering/RHI/Texture.cpp
  • Engine/cpp/Runtime/Rendering/RHI/UniformRegistry.cppm
  • Engine/cpp/Runtime/Rendering/RHI/Vertex.cppm
  • Engine/cpp/Runtime/Rendering/RHI/macros.h
  • Engine/cpp/Runtime/Rendering/RenderGraph/RenderGraph.cpp
  • Engine/cpp/Runtime/Rendering/RenderGraph/RenderGraph.cppm
  • Engine/cpp/Runtime/Rendering/Renderer/Renderer.cpp
  • Engine/cpp/Runtime/Rendering/Renderer/Renderer.cppm
  • Engine/cpp/Runtime/Rendering/Rendering.cppm
  • Engine/cpp/Runtime/Rendering/Shaders/fs.sc
  • Engine/cpp/Runtime/Rendering/Shaders/fs_quad.sc
  • Engine/cpp/Runtime/Rendering/Shaders/varying.def.sc
  • Engine/cpp/Runtime/Rendering/Shaders/varying_quad.def.sc
  • Engine/cpp/Runtime/Rendering/Shaders/vs.sc
  • Engine/cpp/Runtime/Rendering/Shaders/vs_quad.sc
  • Engine/cpp/Runtime/Scene/CMakeLists.txt
  • Engine/cpp/Runtime/Scene/Camera/CameraController.cpp
  • Engine/cpp/Runtime/Scene/Camera/CameraController.cppm
  • Engine/cpp/Runtime/Scene/Renderable/Renderable.cppm
  • Engine/cpp/Runtime/Scene/Scene.cppm
  • Engine/cpp/Runtime/Scene/TransformComponent/TransformComponent.cpp
  • Engine/cpp/Runtime/Scene/TransformComponent/TransformComponent.cppm
  • Engine/cpp/ThirdParty/CMakeLists.txt
  • Engine/cpp/ThirdParty/bgfx
  • Engine/cpp/ThirdParty/bimg
  • Engine/cpp/ThirdParty/bx
  • Engine/cpp/ThirdParty/cmake/Config.cmake.in
  • Engine/cpp/ThirdParty/cmake/bgfx/3rdparty/dear-imgui.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/3rdparty/fcpp.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/3rdparty/glsl-optimizer.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/3rdparty/glslang.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/3rdparty/meshoptimizer.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/3rdparty/spirv-cross.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/3rdparty/spirv-opt.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/3rdparty/tint.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/3rdparty/webgpu.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/CMakeLists.txt
  • Engine/cpp/ThirdParty/cmake/bgfx/bgfx.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/examples.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/geometryc.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/geometryv.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/shaderc.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/shared.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/texturev.cmake
  • Engine/cpp/ThirdParty/cmake/bgfx/util/ConfigureDebugging.cmake
  • Engine/cpp/ThirdParty/cmake/bgfxToolUtils.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/3rdparty/astc_encoder.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/3rdparty/edtaa3.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/3rdparty/etc1.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/3rdparty/etc2.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/3rdparty/iqa.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/3rdparty/libsquish.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/3rdparty/loadpng.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/3rdparty/miniz.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/3rdparty/nvtt.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/3rdparty/pvrtc.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/3rdparty/tinyexr.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/CMakeLists.txt
  • Engine/cpp/ThirdParty/cmake/bimg/bimg.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/bimg_decode.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/bimg_encode.cmake
  • Engine/cpp/ThirdParty/cmake/bimg/texturec.cmake
  • Engine/cpp/ThirdParty/cmake/bx/CMakeLists.txt
  • Engine/cpp/ThirdParty/cmake/bx/bin2c.cmake
  • Engine/cpp/ThirdParty/cmake/bx/bx.cmake
  • Engine/cpp/ThirdParty/cmake/version.cmake
  • Engine/cpp/ThirdParty/doctest/doctest.h
  • Engine/cpp/ThirdParty/doctest/doctest_with_main.h
  • Engine/cpp/ThirdParty/sdl
  • Engine/cpp/ThirdParty/stb/CMakeLists.txt
  • Engine/cpp/ThirdParty/stb/stb_image.h
  • Engine/cpp/runtime/CMakeLists.txt
  • Engine/cpp/runtime/core/CMakeLists.txt
  • Engine/cpp/runtime/rendering/CMakeLists.txt
  • Engine/cpp/runtime/rendering/mesh/mesh.cppm
  • Engine/cpp/runtime/rendering/quad_renderer/quad_renderer.cppm
  • Engine/cpp/runtime/rendering/renderer/renderer.cpp
  • Engine/cpp/runtime/rendering/renderer/renderer.cppm
  • Engine/cpp/runtime/scene/CMakeLists.txt
  • Engine/cpp/runtime/scene/camera/camera_controller.cpp
  • Engine/cpp/runtime/scene/camera/camera_controller.cppm
  • Samples/cpp/CMakeLists.txt
  • Samples/cpp/RenderSample.cpp
  • Samples/cpp/rendering.cpp
  • cmake/Modules.cmake
  • cmake/Shaders.cmake

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

JoltedJon
JoltedJon previously approved these changes Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants