feat(side-menu): animate nested sidebar expand/collapse#2779
Open
illionillion wants to merge 1 commit intoRedocly:mainfrom
Open
feat(side-menu): animate nested sidebar expand/collapse#2779illionillion wants to merge 1 commit intoRedocly:mainfrom
illionillion wants to merge 1 commit intoRedocly:mainfrom
Conversation
Author
|
Friendly ping when you have a moment 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
This PR adds smooth accordion animation for nested items in the left sidebar menu.
Why:
How:
scrollHeightfor smooth open/closerole="menu"for root,aria-hiddenfor collapsed nested lists)prefers-reduced-motionReference
Closes #2778
Tests
src/components/__tests__/menuItemsA11y.test.tsnpm run bundle✅npm test✅npm run e2eERR_INVALID_CHARonx-cypress-file-pathin this environment (workspace path contains non-ASCII characters). CI should validate e2e in standard runner paths.Screenshots (optional)
Befor
Screencast.from.2026-03-10.00-40-19.webm
After
Screencast.from.2026-03-10.00-43-23.webm
Check yourself