feat: respect titles for oneOf variants#2772
Open
susliko wants to merge 1 commit intoRedocly:mainfrom
Open
Conversation
susliko
force-pushed
the
nested-one-of
branch
2 times, most recently
from
e4cfa9e to
6e856b3
Compare
susliko
force-pushed
the
nested-one-of
branch
from
6e856b3 to
344f7e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Hi 👋🏻
This fixes #2772 (comment) when buttons for
oneOfcases do not pick up schema names (or titles, if provided) and just show "object" instead.The fix is to avoid adding
default: undefinedproperty to the FieldModel as it makes further processing fall into allOf cases, which leads to further unwanted changes of structure in hoistOneOfsScreenshots
Before:
After:
Check yourself