Repository navigation
Align with upstream CMFCore#161: contextless_indexes + install profile - #2
Merged
Merged
Conversation
Port the changes made to Products.CMFCore#161 after the first backport: - Reindex every index on move, except those listed in the contextless_indexes property of portal_catalog. SearchableText is the default when the property does not exist; an empty property opts out. - Remove IContextAwareIndexProvider and the built-in providers. - moveObject(object, old_path) returns True/False, updates the modification date and drops a stale entry at the new path. - Flush the indexing queue before a move. - Keep the stock unindex + index flow for catalogs without moveObject. - Add default and uninstall GenericSetup profiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port the changes made to Products.CMFCore#161 since the first backport, and add an install profile.
contextless_indexeslines property ofportal_catalog.IContextAwareIndexProviderand the built-in providers are removed (breaking).CatalogTool.moveObject(object, old_path)no longer takesidxs, updates the modification date, drops a stale entry at the new path and returnsTrue/False.moveObjectkeep the stock unindex + index flow (checked withaq_base).experimental.catalogmoveopt:defaultprofile setscontextless_indexestoSearchableText;uninstallsets it empty.Difference from upstream
To ease adoption, a missing
contextless_indexesproperty defaults toSearchableText, so no profile is required. An empty property opts out. Upstream treats a missing property as "reindex everything".Test plan
pytest: 27 passed