Remove setnafill() invalid input error#7710
Open
deh277 wants to merge 4 commits intoRdatatable:masterfrom
Open
Remove setnafill() invalid input error#7710deh277 wants to merge 4 commits intoRdatatable:masterfrom
deh277 wants to merge 4 commits intoRdatatable:masterfrom
Conversation
update fork
shrektan
approved these changes
Apr 16, 2026
Member
shrektan
left a comment
shrektan
left a comment
There was a problem hiding this comment.
chinese translation is ok for me
jangorecki
reviewed
Apr 16, 2026
|
|
||
| 6. Enhanced tests for OpenMP support, detecting incompatibilities such as R-bundled runtime _vs._ newer Xcode and testing for a manually installed runtime from <https://mac.r-project.org/openmp>, [#6622](https://github.com/Rdatatable/data.table/issues/6622). Thanks to @dvg-p4 for initial report and testing, @twitched for the pointers, @tdhock and @aitap for the fix. | ||
|
|
||
| 7. setnafill() old non-numeric input error message removed from all .po and .pot files.[#7449](https://github.com/Rdatatable/data.table/issues/7449) This reduces clutter and improves file readability, while keeping the new errors in place. Thanks to @MichaelChirico for the issue and @deh277 for the fix. |
Member
There was a problem hiding this comment.
Suggested change
| 7. setnafill() old non-numeric input error message removed from all .po and .pot files.[#7449](https://github.com/Rdatatable/data.table/issues/7449) This reduces clutter and improves file readability, while keeping the new errors in place. Thanks to @MichaelChirico for the issue and @deh277 for the fix. | |
| 7. setnafill() old non-numeric input error message removed from all .po and .pot files. This reduces clutter and improves file readability, while keeping the new errors in place. Thanks to @MichaelChirico for the issue and @deh277 for the fix. [#7449](https://github.com/Rdatatable/data.table/issues/7449) |
jangorecki
added
the
translation
Member
|
Hm sorry I think there's some misunderstanding. The point of the bug as of now is to try using If so, we can just close the bug. The .po / .pot files will get updated in time for the next {data.table} release, there's no need for a PR like this (there are dozens of other messages that would need to be updated in a similarly incremental fashion) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7449
Removed an unused error message from the po and pot files so they are less cluttered and more accurate. The error message removed (“‘x’ argument must be numeric type, or list/data.table of numeric types") is no longer being used since #3992 has changed nafill to allow non-numeric types. We made sure to run the test suite on our repository and everything passed on our end.
Worked on by @deh277 and @shantz14