Skip to content

Translation fr - #503

Merged
Razeeman merged 9 commits into
Razeeman:devfrom
ldmpub:translation-fr
Oct 18, 2026
Merged

Razeeman merged 9 commits into
Razeeman:devfrom
ldmpub:translation-fr

Conversation

@Razeeman

@Razeeman Razeeman commented Oct 2, 2026

Copy link
Copy Markdown
Owner

Original PR auto closed because of branch rename
#493

<string name="statistics_detail_range_averages_non_empty">Uniquement sur les éléments de la plage ayant un enregistrement</string>

<string name="statistics_detail_total_duration">Total</string>
<string name="statistics_detail_total_duration">Solde</string>

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text is also used at the top of the statistics detail screen, there number of records is shown and total tracked duration. Will "Solde" be appropriate there?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common decision: we need 2 translation keys.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 for total and 1 for balance.

@ldmpub

ldmpub commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

@Razeeman Good point. The word "Solde" (i.e., Balance in English) is not appropriate at the top of the statistics detail screen where the "Total tracked duration" is displayed, because this total has no link to any target or objective.

Sorry but I think we need 2 different translation keys in the app.

@Razeeman

Copy link
Copy Markdown
Owner Author

@Razeeman Good point. The word "Solde" (i.e., Balance in English) is not appropriate at the top of the statistics detail screen where the "Total tracked duration" is displayed, because this total has no link to any target or objective.

Sorry but I think we need 2 different translation keys in the app.

Will add a different translation key for the goal balance.

@Razeeman

Copy link
Copy Markdown
Owner Author

Added different translation key for this goal balance.

Key: statistics_detail_goals_balance
Eng: Balance
Fr: Solde

@ldmpub

ldmpub commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Thanks both for the new translation key addition and the translation done in the french ressource file 👍.

CI fails ❌=> AI diagnosis and suggested action to correct this fail

One time correction
In
features/feature_notification/src/main/java/com/example/util/simpletimetracker/feature_notification/external/NotificationExternalBroadcastController.kt
remove unused import at line 8:
com.example.util.simpletimetracker.core.utils.EXTRA_ACTIVITY_NAME

Long time correction
A better solution? To automate this correction, run:
./gradlew :feature_notification:ktlintFormat
=> this removes the unused import and should satisfy ktlint.

Hope this helps 🤞,

@Razeeman

Copy link
Copy Markdown
Owner Author

Thank you for the help!

@Razeeman
Razeeman merged commit 0dc78f2 into Razeeman:dev Oct 18, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants