Expand the AI automation suite: agents, skills, guardrail hooks, and workflows - #565
Open
pusewicz wants to merge 20 commits into
Open
Expand the AI automation suite: agents, skills, guardrail hooks, and workflows#565pusewicz wants to merge 20 commits into
pusewicz wants to merge 20 commits into
Conversation
check-include-guard.py derived expected guards purely from filename, false-nagging cute_time.h (CF_TIMER_H), cute_doubly_list.h (CF_DOUBLY_LINKED_LIST_H), and cute_debug_printf.h (deliberately no guard). Added LEGACY_GUARDS/NO_GUARD escape hatches plus a sweep test over all of include/*.h. Also null-guard the flatMap calls in branch-review.js and docs-audit.js against missing findings/issues arrays, normalize check-docs-tags.py to 644 like the other hooks, and widen its own header sweep test to include cute.h.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the repository’s AI automation collateral under .claude/ and updates AGENTS.md to document the new agents/skills/hooks/workflows and to standardize the “deprecation-in-prose” documentation convention (avoid @deprecated tags that break the docs parser).
Changes:
- Adds Claude Code workflows for branch review and docs-vs-implementation auditing.
- Adds skills and agents capturing project practices (tests, CMake, perf, docs, samples, research).
- Adds/edit hooks (and a Python test harness) to block generated-file edits and warn on include-guard/docs-tag/registration issues.
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Documents .claude/ automation and updates deprecation guidance to prose (no @deprecated tag). |
| .claude/workflows/docs-audit.js | New workflow to audit header doc comments vs src/ implementations (report-only). |
| .claude/workflows/branch-review.js | New multi-agent workflow for pre-PR review with adversarial verification. |
| .claude/skills/test-writing/SKILL.md | New skill documenting CF’s pico_unit test workflow and registration traps. |
| .claude/skills/perf-benchmarking/SKILL.md | New skill defining a repeatable benchmarking methodology and reporting requirements. |
| .claude/skills/header-api-review/SKILL.md | Updates header API review guidance to deprecate via prose (no @deprecated tag). |
| .claude/skills/cmake-conventions/SKILL.md | New skill describing consumable-framework CMake conventions and registration points. |
| .claude/settings.json | Wires additional PostToolUse hooks (docs tags + registration). |
| .claude/hooks/tests/test_hooks.py | Adds hook test harness covering block/warn behaviors and regression sweeps. |
| .claude/hooks/tests/fixtures/include/cute_wrongguard.h | Fixture for include-guard mismatch warning. |
| .claude/hooks/tests/fixtures/include/cute_nocopyright.h | Fixture for missing copyright warning. |
| .claude/hooks/tests/fixtures/include/cute_midtoken.h | Fixture ensuring mid-token @ doesn’t trigger docs-tag warnings. |
| .claude/hooks/tests/fixtures/include/cute_goodfixture.h | Fixture representing a clean header for hook tests. |
| .claude/hooks/tests/fixtures/include/cute_badtag.h | Fixture containing unsupported @tags to ensure hook warns. |
| .claude/hooks/check-registration.py | New hook warning on missing build/test/sample/header registration. |
| .claude/hooks/check-include-guard.py | Enhances include-guard hook to also warn on missing copyright, with legacy/no-guard allowlists. |
| .claude/hooks/check-docs-tags.py | New hook warning on docs-parser-breaking @tags anywhere in headers. |
| .claude/hooks/block-generated-files.py | Extends generated-file blocking to include cute_version.h/.cpp configure_file outputs. |
| .claude/agents/software-architect.md | New agent guidance for producing implementation plans (read-only). |
| .claude/agents/sample-writer.md | New agent guidance for writing/registering/verifying samples. |
| .claude/agents/researcher.md | New agent guidance for evidence-backed technical research (read-only). |
| .claude/agents/performance-engineer.md | New agent guidance for measured optimization work. |
| .claude/agents/doc-writer.md | New agent guidance for public-header doc comment editing and docs_parser constraints. |
| .claude/agents/code-writer.md | New agent guidance for implementing changes with CF conventions and verification. |
| .claude/agents/code-reviewer.md | New agent guidance for defect-focused reviews and verification expectations. |
| .claude/agents/cf-api-reviewer.md | Updates API reviewer guidance to match prose deprecation convention. |
| .claude/.gitignore | Adds a .claude-scoped gitignore rule to keep /agents/ unignored. |
Comment on lines
+65
to
+70
| main_cpp = read("test/main.cpp") | ||
| if not registered(stem, main_cpp): | ||
| problems.append( | ||
| f"suite '{stem}' is not registered in test/main.cpp " | ||
| f"(needs TEST_SUITE({stem}); and RUN_TRACED({stem});)." | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #482 (cf-api-reviewer + hooks) into a full day-to-day roster for AI-assisted work on CF. Everything lives under
.claude/andAGENTS.md— no framework code or CI changes.python3 .claude/hooks/tests/test_hooks.py, 27 passing): block edits to generated files (*_shd.h, the configure_file version files), warn on include-guard/copyright drift, on@tagsthe docs parser panics on, and on src/test/sample files missing their build registration. Swept against every real header/source — zero false positives (legacy guards likeCF_TIMER_Hand the deliberately guard-lesscute_debug_printf.hare whitelisted).@brief/@remarks, never an@deprecatedtag (which panics the docs parser).🤖 Generated with Claude Code
https://claude.ai/code/session_01PAgU7PxUwMJ8416AfRK3HA