Skip to content

Make the cache actually bypass syscalls #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alcaro wants to merge 2 commits into
base: asar_2_beta
Choose a base branch
from
Open

Make the cache actually bypass syscalls #399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e5f48d
Make the cache actually bypass syscalls
Alcaro Apr 21, 2026
d3ca575
let's use \x80 instead of \x00, asar's string type is weird about nuls
Alcaro Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/asar/math_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,13 @@ cachedfile * opencachedfile(string fname, bool should_error)

const char* current_file = get_current_file_name();

// RPG Hacker: Only using a combined path here because that should
// hopefully result in a unique string for every file, whereas
// fname could be a relative path, which isn't guaranteed to be unique.
// Note that this does not affect how we open the file - this is
// handled by the filesystem and uses our include paths etc.
string combinedname = filesystem->create_absolute_path(dir(current_file), fname);
// do not call filesystem->create_absolute_path() here - that requires file existence syscalls, largely defeating the point of the cache
// \x80 is impossible to have in a filename without Asar complaining about invalid utf8
string cache_key = dir(current_file) + "\x80" + fname;

for (int i = 0; i < numcachedfiles; i++)
{
if (cachedfiles[i].used && cachedfiles[i].filename == combinedname)
if (cachedfiles[i].used && cachedfiles[i].filename == cache_key)
{
cachedfilehandle = &cachedfiles[i];
break;
Expand All @@ -62,7 +59,7 @@ cachedfile * opencachedfile(string fname, bool should_error)
if (cachedfilehandle->filehandle != INVALID_VIRTUAL_FILE_HANDLE)
{
cachedfilehandle->used = true;
cachedfilehandle->filename = combinedname;
cachedfilehandle->filename = cache_key;
cachedfilehandle->filesize = filesystem->get_file_size(cachedfilehandle->filehandle);
cachedfileindex++;
// randomdude999: when we run out of cached files, just start overwriting ones from the start
Expand Down
Loading