fix: use bounded strlcpy/snprintf in io-mpi.c#199
Open
orbisai0security wants to merge 16 commits into
Open
Conversation
New ROSS version 8.1.0 !
… calling tw_trigger_gvt_hook_now
Fixing GVT hook trigger when called by LPs
Adding basic GitHub Actions CI build. Just one linux build with mpich for now. Removed .travis.yml
RISA is quite old and relies on a very old version of Damaris. Disabling for now, with plans to rewrite RISA in the future.
Removing the USE_DAMARIS path in the build since RISA is quite out of date and I highly doubt anyone uses it. Will hopefully do a rewrite of RISA in the future! Removed old coveralls build and added codecov. Apparently we had it enabled previously, so it is comparing coverage of this PR to 5 years ago, so the comparison is not meaningful. I believe future PRs would then have coverage compared to recent changes after this is merged. We can explore increasing coverage in the future. Removed the ross-config because AFAICT it's not actually used by CODES. I locally tested a CODES build after removing it and it was fine. As part of this overhaul of CMake and CI, I'll eventually add a contract test in ROSS CI so we can ensure PRs don't break CODES Also this PR adds an initial CLAUDE.md file as I've been using it for development.
Two unbounded strcpy calls in core/rio/io-mpi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
core/rio/io-mpi.c.Vulnerability
V-001core/rio/io-mpi.c:39Description: Two unbounded strcpy calls in core/rio/io-mpi.c copy external strings into fixed-size buffers without any length validation. At line 39, strcpy(model_version, sha1) copies a SHA1 string from checkpoint metadata into a fixed buffer. At line 108, strcpy(g_io_checkpoint_name, master_filename) copies a user-supplied filename without bounds checking. If either source string exceeds the destination buffer size, the overflow overwrites adjacent stack memory including return addresses or saved frame pointers, enabling arbitrary code execution.
Changes
core/rio/io-mpi.cVerification
Automated security fix by OrbisAI Security