fix(rpp): Fix libomp search to include clang target triple directory - #515
Merged
Merged
Conversation
zichguan-amd
reviewed
Sep 3, 2026
zichguan-amd
left a comment
zichguan-amd
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the comprehensive fix. LGTM with some comments.
With -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON the libomp.so library is moved one level down to something like 'x86_64-unknown-linux-gnu'. This adds a cmake helper file, FindOpenMPHelpers.cmake, which first looks for the openmp-config.cmake via find_package(OpenMP CONFIG) and then falls back to find_library(omp) with the clang target triple added to suffixes. Updates: RPP/box_filter RPP/brightness RPP/contrast RPP/flip RPP/gamma_correction RPP/resize Reverts the hard coded path in #513 ISSUE ID: ROCM-30536
estewart08
force-pushed
the
users/estewart/rpp-fix-libomp-search
branch
from
September 3, 2026 17:14
efa0c84 to
6ce8d4b
Compare
Contributor
Author
|
@zichguan-amd, I assume this needs moved to amd-mainline? What is the timeline on that? |
Collaborator
Mainline promotion happens automatically on Monday, if this is urgent I can manually promote. |
Contributor
Author
Monday is fine. Can you confirm if the failures are known/unrelated? |
Collaborator
|
Yes the rocprofiler-sdk failures are unrelated and being fixed by another PR. You can merge whenever. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON the libomp.so library is moved one level down to something like 'x86_64-unknown-linux-gnu'. This adds a cmake helper file, FindOpenMPHelpers.cmake, which first looks for the openmp-config.cmake via find_package(OpenMP CONFIG) and then falls back to find_library(omp) with the clang target triple added to suffixes.
Updates:
RPP/box_filter
RPP/brightness
RPP/contrast
RPP/flip
RPP/gamma_correction
RPP/resize
Reverts the hard coded path in #513
Motivation
Fix openmp examples search methodology for libomp.so
Technical Details
Adds cmake helper in Common/FindOpenMPHelpers.cmake
Test Plan
Configure/execution of rpp examples.
Test Result
Tests should configure/run with no missing libomp.so errors.
ISSUE ID: ROCM-30536