fix(ci): unbreak nightly whl build (hipThreads skip + box_filter libomp) - #513
Merged
Conversation
…bomp The TheRock nightly whl ships hipthreads headers + libhipthreads.a but an empty include/libhipcxx (ROCm/TheRock#7530), so every hipthreads-linked example fails to compile. Add a nightly build-skip for the whole Libraries/hipThreads tree in the skip manifest and wire Libraries/Makefile with the skip_here machinery (mirroring HIP-Basic/Makefile) so the Make build honors SKIP_FROM_BUILD/SKIP_FROM_TEST. Separately, RPP/box_filter's find_library(omp) missed the wheel's bundled libomp, which lives under lib/llvm/lib/x86_64-unknown-linux-gnu/. Add that triplet dir to PATH_SUFFIXES so the required OMP_LIBRARY resolves across distros without a system libomp package. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
…eaders The ubuntu-24.04/26.04 multiarch Dockerfile headers pointed users at a ./run-tests.sh helper that was never committed to the repo. Remove the stale "Run tests (preferred)" block. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two failures in the nightly TheRock whl (
whl-multi-arch) CI build, validated end-to-end in a local multiarch container against10.1.0a20260902(current latest).libhipthreads.abut an emptyinclude/libhipcxx/(Disable libhipcxx and hipthreads TheRock#7530), so every hipthreads-linked example fails withfatal error: 'hip/atomic' file not found. Added a nightly build-skip for the wholeLibraries/hipThreadstree inskip_manifest.py, and wiredLibraries/Makefilewith theskip_heremachinery (mirroringHIP-Basic/Makefile) so the Make build honorsSKIP_FROM_BUILD/SKIP_FROM_TEST. The CMake side was already covered byCommon/SkipExamples.cmake.RPP/box_filter'sfind_library(omp REQUIRED)missed the wheel's bundled libomp, which lives underlib/llvm/lib/x86_64-unknown-linux-gnu/. Added that triplet dir toPATH_SUFFIXESso it resolves across distros with no system libomp package../run-tests.shreference (a helper never committed) from the ubuntu-24.04/26.04 Dockerfile headers.Validation (local multiarch container, nightly whl
10.1.0a20260902)SKIP_FROM_BUILD=Libraries/hipThreadsand writes.github/build_tools/skip_build.txt.make -C Libraries hipThreads SKIP_FROM_BUILD=Libraries/hipThreadsdrops it, no compile attempted.SkipExamples: skipping Libraries/hipThreads (build-skip manifest), configure exits 0.lddconfirms it links.../lib/llvm/lib/x86_64-unknown-linux-gnu/libomp.so.Test plan
whl-multi-archCI build is green (hipThreads skipped, RPP/box_filter builds)Libraries/hipThreadsbuild skip on the nightly channelchannels: ["nightly"]-scoped)🤖 Generated with Claude Code