Skip to content

chore: add CODEOWNERS for the maintainers team - #148

Merged
rominf merged 1 commit into
mainfrom
chore/codeowners
Jul 29, 2026
Merged

chore: add CODEOWNERS for the maintainers team#148
rominf merged 1 commit into
mainfrom
chore/codeowners

Conversation

@rominf

@rominf rominf commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Pull requests currently get a reviewer only if the author remembers to pick one.

Adds .github/CODEOWNERS with a single catch-all entry pointing at @ROCm/rocm-cli-maintainers, so GitHub requests a review from the maintainers team on every pull request.

Two supporting changes were made on the repo settings side, since a CODEOWNERS entry is inert without them:

  • the rocm-cli-maintainers team had no access to this repository, which would have made the entry an invalid owner — it now has write access;
  • main branch protection will require an approval from a code owner once this lands.

Reviewer membership is managed through the team, not this file.

Every pull request now automatically requests a review from
@ROCm/rocm-cli-maintainers, so review requests no longer depend on the
author remembering to pick someone.

Signed-off-by: Roman Inflianskas <Roman.Inflianskas@amd.com>
@rominf
rominf added this pull request to the merge queue Jul 29, 2026
Merged via the queue into main with commit ca9f297 Jul 29, 2026
21 checks passed
@rominf
rominf deleted the chore/codeowners branch July 29, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants