[CP 1403] Discover DRA API version dynamically for DeviceClass creation#537
Open
ci-penbot-01 wants to merge 1 commit intoROCm:mainfrom
Open
Conversation
On OpenShift 4.19/4.20 (K8s 1.32/1.33), the resource.k8s.io/v1 API is not available — only v1beta1 or v1beta2. The hardcoded v1 GVK caused DeviceClass creation to silently fail, breaking all DRA tests. Use the discovery client to probe for the highest available API version (v1 > v1beta2 > v1beta1) before creating the DeviceClass. Verified on OCP 4.19 (K8s 1.32): operator discovers v1beta1 and creates the DeviceClass successfully. (cherry picked from commit 7fae45ad8cb77a4af61f38933a56070685b995f1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp of pensando/gpu-operator#1403
Source PR Description (pensando/gpu-operator#1403):
On OpenShift 4.19/4.20 (K8s 1.32/1.33), the resource.k8s.io/v1 API is not available — only v1beta1 or v1beta2. The hardcoded v1 GVK caused DeviceClass creation to silently fail, breaking all DRA tests.
Use the discovery client to probe for the highest available API version (v1 > v1beta2 > v1beta1) before creating the DeviceClass.
Cherrypick triggered by: ACP-Automation