[Build] Centralize component source roots via env vars - #2507
Merged
Conversation
Add AOMP_PROJECT_SRC, AOMP_SPIRV_SRC, and AOMP_SRC to aomp_common_vars and use them throughout the build_* scripts instead of hardcoding $AOMP_REPOS/<name>. Defaults preserve the historical $AOMP_REPOS layout, so behavior is unchanged when the variables are unset. This lets a single environment override redirect one component's source (e.g. to a per-task git worktree) without relocating the shared checkout of every other component. The llvm-project monorepo root is read by eight build scripts (project, offload, openmp, llvm_runtimes_standalone, comgr, libdevice, hipcc, extras) and must move together for a staged build to stay consistent; the previously hardcoded SPIRV-LLVM-Translator source is now overridable too. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jplehr
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
September 4, 2026 11:57
ronlieb
approved these changes
Sep 4, 2026
mhalk
approved these changes
Sep 4, 2026
mhalk
left a comment
mhalk
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Nice consolidation :)
Collaborator
|
BTW I checked out this branch, ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AOMP_PROJECT_SRC, AOMP_SPIRV_SRC, and AOMP_SRC to aomp_common_vars and use them throughout the build_* scripts instead of hardcoding $AOMP_REPOS/. Defaults preserve the historical $AOMP_REPOS layout, so behavior is unchanged when the variables are unset.
This lets a single environment override redirect one component's source (e.g. to a per-task git worktree) without relocating the shared checkout of every other component. The llvm-project monorepo root is read by eight build scripts (project, offload, openmp, llvm_runtimes_standalone, comgr, libdevice, hipcc, extras) and must move together for a staged build to stay consistent; the previously hardcoded SPIRV-LLVM-Translator source is now overridable too.