Skip to content

[ROCM-28989] Fix msgpack symbol conflict - #5118

Open
shivadbhavsar wants to merge 4 commits into
developfrom
msgpack_visibility
Open

[ROCM-28989] Fix msgpack symbol conflict#5118
shivadbhavsar wants to merge 4 commits into
developfrom
msgpack_visibility

Conversation

@shivadbhavsar

@shivadbhavsar shivadbhavsar commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Motivation

See #4366

Technical Details

Change visibility settings on exported headers

Changelog Category

Add a CHANGELOG.md entry for any option other than Not Applicable

    • Added: New functionality.
    • Changed: Changes to existing functionality.
    • Removed: Functionality or support that has been removed. (Compared to a previous release)
    • Optimized: Component performance that has been optimized or improved.
    • Resolved Issues: Known issues from a previous version that have been resolved.
    • Not Applicable: This PR is not to be included in the changelog.

Follow the LLVM AI Tool Use Policy for contributions using AI.

@shivadbhavsar shivadbhavsar self-assigned this Aug 6, 2026
@shivadbhavsar
shivadbhavsar requested a review from causten as a code owner August 6, 2026 16:51
@shivadbhavsar
shivadbhavsar requested review from TedThemistokleous and pfultz2 and a lite review from Copilot August 6, 2026 16:51
Copilot AI reviewed Aug 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@TedThemistokleous TedThemistokleous added high priority A PR with high priority for review and merging. simple small or simple changes Windows Related changes for Windows Environments bugfix Fixes a bug found in the code. and removed Windows Related changes for Windows Environments labels Aug 6, 2026
@causten
causten requested a balanced review from Copilot August 6, 2026 17:52
Copilot AI reviewed Aug 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@TedThemistokleous TedThemistokleous TedThemistokleous approved these changes
@causten causten Awaiting requested review from causten causten is a code owner
@pfultz2 pfultz2 Awaiting requested review from pfultz2

Assignees

@shivadbhavsar shivadbhavsar

Labels

bugfix Fixes a bug found in the code. high priority A PR with high priority for review and merging. simple small or simple changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shivadbhavsar @TedThemistokleous