Skip to content

[CI] Run CI-Pipeline and GPU CI on PRs targeting test - #307

Merged
maxiaosong1124 merged 1 commit into
RL-Align:testfrom
maxiaosong1124:ci/enable-test-branch-triggers
Aug 13, 2026
Merged

[CI] Run CI-Pipeline and GPU CI on PRs targeting test#307
maxiaosong1124 merged 1 commit into
RL-Align:testfrom
maxiaosong1124:ci/enable-test-branch-triggers

Conversation

@maxiaosong1124

@maxiaosong1124 maxiaosong1124 commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

PRs are now required to target test, but the gate workflows still only listed main as the base branch. As a result, CI-Pipeline and GPU CI never started on those PRs (see #305).

This change only updates the trigger filters:

  • .github/workflows/ci.yml: push / pull_request now include test
  • .github/workflows/gpu-ci.yml: pull_request_target now includes test

docs.yml and build-ci-image.yml stay on main (Pages deploy and CI image publish).

Why this needs to land on test first

gpu-ci.yml uses pull_request_target, which reads the workflow file from the base branch, not the PR head. Until this commit is on test, GPU CI cannot run for any PR targeting test.

After merge

  • Existing PRs targeting test should pick up CI-Pipeline on the next push, or after close/reopen.
  • GPU CI still requires the needs-gpu-ci label.
  • Fork PRs still cannot use same-repo-only workflows such as WS1-gtest-GPU.

Test plan

  • Confirm this PR itself starts CI-Pipeline after the workflow is on test (first-run may need a follow-up push or close/reopen).
  • After merge, confirm a test-based PR without needs-gpu-ci still runs CI-Pipeline.
  • After merge, add needs-gpu-ci to a test-based PR and confirm GPU CI starts.

Summary by CodeRabbit

  • Chores
    • Expanded automated validation to run for changes targeting both the main and test branches.
    • Included GPU-specific validation for pull requests targeting the test branch.

CI-Pipeline and GPU CI only triggered on main, so PRs targeting
test never started the required checks. Keep docs/image publish
workflows on main.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b84887f7-a01a-4722-882f-84673c649779

📥 Commits

Reviewing files that changed from the base of the PR and between 505512d and c0e37db.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/gpu-ci.yml

📝 Walkthrough

Walkthrough

The CI and GPU CI workflows now trigger for the test branch in addition to main.

Changes

CI trigger coverage

Layer / File(s) Summary
Workflow trigger updates
.github/workflows/ci.yml, .github/workflows/gpu-ci.yml
The workflows now include test in their branch filters for push, pull request, and pull request target events.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: 🔵 Low · up to c0e37

This change enables GPU CI for pull requests targeting test through a privileged workflow path. It is mergeable with explicit owner confirmation that test has equivalent protections and that pull-request inputs cannot expose runner secrets.

Possibly related PRs

  • RL-Align/RL-Kernel#105: Both PRs modify the GPU CI trigger configuration, but this PR changes branch targeting.

Suggested reviewers: bitborne, flink-ddd, liuzin521

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: enabling CI-Pipeline and GPU CI for pull requests targeting the test branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Flink-ddd Flink-ddd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for update.

@maxiaosong1124
maxiaosong1124 merged commit 3ead618 into RL-Align:test Aug 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants