[CI] Run CI-Pipeline and GPU CI on PRs targeting test - #307
Conversation
CI-Pipeline and GPU CI only triggered on main, so PRs targeting test never started the required checks. Keep docs/image publish workflows on main.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe CI and GPU CI workflows now trigger for the ChangesCI trigger coverage
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: 🔵 Low · up to This change enables GPU CI for pull requests targeting test through a privileged workflow path. It is mergeable with explicit owner confirmation that test has equivalent protections and that pull-request inputs cannot expose runner secrets. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Flink-ddd
left a comment
There was a problem hiding this comment.
LGTM, Thank you for update.
Summary
PRs are now required to target
test, but the gate workflows still only listedmainas the base branch. As a result,CI-PipelineandGPU CInever started on those PRs (see #305).This change only updates the trigger filters:
.github/workflows/ci.yml:push/pull_requestnow includetest.github/workflows/gpu-ci.yml:pull_request_targetnow includestestdocs.ymlandbuild-ci-image.ymlstay onmain(Pages deploy and CI image publish).Why this needs to land on
testfirstgpu-ci.ymlusespull_request_target, which reads the workflow file from the base branch, not the PR head. Until this commit is ontest, GPU CI cannot run for any PR targetingtest.After merge
testshould pick upCI-Pipelineon the next push, or after close/reopen.needs-gpu-cilabel.WS1-gtest-GPU.Test plan
CI-Pipelineafter the workflow is ontest(first-run may need a follow-up push or close/reopen).test-based PR withoutneeds-gpu-cistill runsCI-Pipeline.needs-gpu-cito atest-based PR and confirmGPU CIstarts.Summary by CodeRabbit