Repository navigation
feat(extension): reveal the current chapter from the status bar - #91
Merged
Merged
Conversation
Clicking the status item used Next Chapter, so an accidental click switched the applied snapshot. The item now focuses the course view and scrolls to the applied chapter instead, reusing the title-bar jump command and its localized title. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking the chapter status item in the status bar ran Next Chapter, so a click that meant “show me where I am” silently applied the next chapter’s start snapshot.
learnByDiff.scrollToCurrentChapter; the item tooltip becomes “Scroll to Current Chapter” (bundle.l10n*.jsonin en / zh-cn / zh-tw / ja).focusoption toCourseTreeProvider.revealCurrentChapter. The status bar (and the view title jump) now focus the course view and scroll to the applied chapter without expanding or selecting the row; the post-apply reveal keepsfocus: falseso a chapter switch does not steal focus.docs/architecture.md.Closes #90
Test plan
pnpm exec vp checkpnpm exec vp run -r testpnpm exec vp run learn-by-diff#packsandbox/: clicking the status bar chapter item focuses Learn By Diff and scrolls to the current chapter, without applying the next chapterMade with Cursor