Repository navigation
chore(git): format staged files in the commit hook - #88
Merged
Merged
Conversation
The commit hook previously ran the whole `vp check`, so a commit paid for type checks that CI already covers. Run the formatter and lint fixers on staged files instead, which rewrites and re-stages them before the commit.
RJiazhen
force-pushed
the
chore/format-hook-ci
branch
from
October 19, 2026 05:06
2846288 to
09a45ed
Compare
RJiazhen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp check --fix, which included type checks already covered by CI.stagednow runs["vp fmt --write", "vp lint --fix"]on staged files, so they are formatted and lint-fixed (and re-staged) before the commit lands.checkjob still runsvp check, so formatting keeps being verified there.Test plan
pnpm exec vp fmt --checkfails (exit 1) on an unformatted staged filepnpm exec vp staged/.vite-hooks/pre-commitreformats staged files and updates the indexpnpm exec vp fmt --checkpasses on the whole repocheckpasses on this PRNo protocol
srcchanges, so no protocol pack or extension F5 needed.