Skip to content

Record workflow stage timings in shared execution helpers - #221

Merged
yoshifuminakamura merged 2 commits into
developfrom
feature/sbd-stage-timing
Sep 18, 2026
Merged

yoshifuminakamura merged 2 commits into
developfrom
feature/sbd-stage-timing

Conversation

@yoshifuminakamura

@yoshifuminakamura yoshifuminakamura commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Shared execution helpers now record UTC start/end timestamps, monotonic elapsed seconds and exit codes for benchmark execution, profiler collection/export and NCU plan generation. bk_profiler records its acquisition and export commands automatically. Applications with custom MPI or container launchers use bk_profile_execute; they do not manage clocks, timing files or artifact registration.

SBD and GENESIS use the shared helpers, including GENESIS host and container profiling. Records are scoped by execution session and experiment, then collected by the common Result emitter and uploaded through Measurement Artifacts. Existing application timing observations are preserved, and QWS profiling sets its CASE scope explicitly. Recorder failures do not replace command exit codes; interrupted stages retain their start record.

Result Detail also links uploaded discovery, plan and profile metadata JSON on the authenticated console surface. Public artifact visibility is unchanged.

Validation:

  • Profile-data shell tests across common, result-sender and estimation groups.
  • Common timing tests cover failures, timeout exit codes, interruption, output routing, subprocess contexts, session isolation, Result filtering and artifact upload without fixing elapsed-time values.
  • Fake-profiler integration tests cover SBD, GENESIS host/container paths and automatic fapp/NCU collection/export recording.
  • Result Detail tests cover metadata links, missing uploads, invalid paths and public/console visibility.
  • Shell syntax, Shellcheck and repository policy checks.

Stage wall times are distinct from application FOM and do not by themselves measure profiler slowdown. A scheduler kill can prevent artifact upload even though completed-stage records remain on disk.

Real hardware validation of the new shared timing records remains pending.

Signed-off-by: yoshifuminakamura <nakamura@riken.jp>
Signed-off-by: yoshifuminakamura <nakamura@riken.jp>
@yoshifuminakamura yoshifuminakamura changed the title Record SBD stage timings and link profile metadata Record workflow stage timings in shared execution helpers Sep 18, 2026
@yoshifuminakamura
yoshifuminakamura merged commit 91dba97 into develop Sep 18, 2026
9 checks passed
@yoshifuminakamura
yoshifuminakamura deleted the feature/sbd-stage-timing branch September 18, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant