Record workflow stage timings in shared execution helpers - #221
Merged
Merged
Conversation
Signed-off-by: yoshifuminakamura <nakamura@riken.jp>
Signed-off-by: yoshifuminakamura <nakamura@riken.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared execution helpers now record UTC start/end timestamps, monotonic elapsed seconds and exit codes for benchmark execution, profiler collection/export and NCU plan generation.
bk_profilerrecords its acquisition and export commands automatically. Applications with custom MPI or container launchers usebk_profile_execute; they do not manage clocks, timing files or artifact registration.SBD and GENESIS use the shared helpers, including GENESIS host and container profiling. Records are scoped by execution session and experiment, then collected by the common Result emitter and uploaded through Measurement Artifacts. Existing application timing observations are preserved, and QWS profiling sets its CASE scope explicitly. Recorder failures do not replace command exit codes; interrupted stages retain their start record.
Result Detail also links uploaded discovery, plan and profile metadata JSON on the authenticated console surface. Public artifact visibility is unchanged.
Validation:
Stage wall times are distinct from application FOM and do not by themselves measure profiler slowdown. A scheduler kill can prevent artifact upload even though completed-stage records remain on disk.
Real hardware validation of the new shared timing records remains pending.