docs: correct reReturnCode's stale fallback description (post aicshud/WHEEL#1017) - #144
Merged
so5 merged 1 commit intoSep 17, 2026
Conversation
…/WHEEL#1017) aicshud/WHEEL#1017 changed getStatusCode()'s fallback for when reReturnCode doesn't match (or captures nothing) from a hardcoded "return value = -2" to instead judging success/failure from the job status code obtained via reJobStatus/reJobStatusCode (isJobFailed()) - because a job that never produced its own exit code (canceled, held, etc.) can still have a perfectly fine status code, and hardcoding -2 unconditionally failed it. The admin-facing docs (ja/en) for reReturnCode still described the old "-2" behavior, left stale by that fix since it never touched documentMD. Update both to describe the current fallback accurately. Found while auditing every change merged to main since the last successful docs build (PR RIKEN-RCCS#126) for anything requiring a documentation update, at the user's request (aicshud/WHEEL#1029). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C3jKNM1qubomM8UTRdkEWu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aicshud/WHEEL#1017(merged) changedgetStatusCode()'s fallback for whenreReturnCodedoesn't match (or captures nothing) from a hardcoded "return value = -2" to instead judging success/failure from the job status code obtained viareJobStatus/reJobStatusCode(isJobFailed()) - because a job that never produced its own exit code (canceled, held, etc.) can still have a perfectly fine status code, and hardcoding -2 unconditionally failed it.The admin-facing docs (ja/en) for
reReturnCodestill described the old "-2" behavior, left stale by that fix since it never toucheddocumentMD.What changed
Updated both
documentMD/user_guide/_for_admins/job_scheduler/index.mdandindex.en.mdto describe the current fallback accurately.Found while auditing every change merged to
mainsince the last successful docs build (PR #126) for anything requiring a documentation update, at the user's request.Note on merge timing
Per the user: this PR should be merged after the
github-pagesenvironment's deployment-branch protection rule is updated to allowmain(currently still restricted to the oldmasterbranch name, causing every docs deploy to fail with "Branch main is not allowed to deploy to github-pages due to environment protection rules"). Merging beforehand is harmless (this doc-only change doesn't depend on that fix), but the user wants it as the last item merged in this batch so the fixed pipeline's first successful deploy already includes this correction.Related
Filed against
aicshud/WHEEL#1029on GitLab (issue tracker for this project). Referencesaicshud/WHEEL#1017.🤖 Generated with Claude Code
https://claude.ai/code/session_01C3jKNM1qubomM8UTRdkEWu