fix(dispatcher): _getState() reports "stopped" for a genuine external stop (aicshud/WHEEL#1028)

[so5]

Summary

Fixes aicshud/WHEEL#1028: _getState() never returned "stopped", the documented state for an externally-stopped project (documentMD/user_guide/_reference/3_workflow_screen/1_graphview.md), even though start()'s onStop handler sets stoppedExternally (aicshud/WHEEL#1020) specifically to record that case.

Currently masked at the whole-project level because onStopProject() unconditionally force-overwrites the project state to "stopped" afterward - but runProject() also writes _getState()'s (wrong) return value straight to the root workflow component's own cmp.wheel.json, so that component's own recorded state stayed wrong ("finished"/"failed"/"unknown") even though the project overall correctly showed "stopped".

What changed

• _getState() now falls through to "stopped" once hasUnknownComponent/hasFailedComponent are ruled out, instead of never reporting the documented "stopped" state at all. Checked last, not first: stopProject() is also used to abort the rest of a project when one of its own tasks fails (the "taskStateChanged" listener in handlers/projectController.js), and that path already records the failure via setStateFlag() before remove() runs - hasFailedComponent/hasUnknownComponent must keep taking priority over stoppedExternally there, matching the existing "failed must not be clobbered by stopped" contract (issue #1000).
• Moved where stoppedExternally is set from the generic "stop" handler (onStop, inside start()) to remove() itself, the one and only caller of which is stopProject(). pause() is also called directly by _jumpHandler's "break" handling as a normal, successful in-workflow loop exit - not a stop - and both emit the same "stop" event that onStop listens for, so leaving the flag in the generic handler would have made a break-terminated loop's own state incorrectly report "stopped" too.

Testing

• Test-first: red test committed separately, then the fix. Also updated the existing #1020 test to call remove() (what stopProject() actually calls) instead of a bare pause(), and added a new test confirming a bare pause() (the "break" path) does NOT set stoppedExternally.
• npm run testDocker -w server — full suite green (1669 passing, 15 pending, 0 failing).

Related

Filed against aicshud/WHEEL#1028 on GitLab (issue tracker for this project). Builds on aicshud/WHEEL#1020 (#140, merged), #1023 (#141, merged), #1027 (#142, merged).

🤖 Generated with Claude Code

https://claude.ai/code/session_01C3jKNM1qubomM8UTRdkEWu