Repository navigation
test: skip mock IPC tests on CRAN and fix mock server races - #76
Merged
Merged
Conversation
Closed
Collaborator
|
Thanks for this @eitsupi. I've been slammed at work and just coming up for air. We need to submit this patch for CRAN. Is there anything else that you'd like to roll into a 0.2.1 release? (I'll open a separate submission issue later today.) |
Member
Author
|
Thank you. I don't have anything in particular to add. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRAN's MKL check exposed a race in the mock test server: the Unix socket path can appear before the server is listening. A refused connection leaves the subprocess waiting, and the old collector then compares a NULL exit status with zero, producing a secondary error.
Skip subprocess/socket integration tests on CRAN at the shared local and TCP mock-server entry points, including direct callers. Publish local readiness only after socket creation and a zero-timeout poll starts connection waiting. On Windows, this registers ConnectNamedPipe before a fast client can connect and close, avoiding ERROR_NO_DATA during the first blocking poll. Share collection logic that terminates timed-out subprocesses and distinguishes unknown, nonzero, and successful exit statuses. Manage temporary paths in the caller's scope with withr.
The existing R check workflow sets NOT_CRAN=true, so integration tests continue to run in CI. No production transport, package version, or E2E workflow changes are needed.
Validation:
Fixes #75