qkc/types: add root and minor blocks - #36
Open
blockchaindevsh wants to merge 3 commits into
Open
Conversation
blockchaindevsh
requested review from
iteyelmp,
ping-ke,
qizhou,
qzhodl and
syntrust
July 11, 2026 15:14
This was referenced Jul 13, 2026
blockchaindevsh
force-pushed
the
qkc-3-types-04-transactions
branch
from
July 22, 2026 15:58
a53fef1 to
45f102f
Compare
blockchaindevsh
force-pushed
the
qkc-3-types-05-blocks
branch
from
July 22, 2026 15:59
7eead44 to
9a5b6d1
Compare
blockchaindevsh
force-pushed
the
qkc-3-types-04-transactions
branch
from
July 23, 2026 11:35
bd79a6f to
1e3f38e
Compare
blockchaindevsh
force-pushed
the
qkc-3-types-05-blocks
branch
from
July 23, 2026 11:35
9a5b6d1 to
384e610
Compare
iteyelmp
reviewed
Jul 24, 2026
| CoinbaseAmount *TokenBalances `json:"coinbaseAmount" gencodec:"required"` | ||
| Time uint64 `json:"timestamp" gencodec:"required"` | ||
| Difficulty *big.Int `json:"difficulty" gencodec:"required"` | ||
| ToTalDifficulty *big.Int `json:"total_difficulty" gencodec:"required"` |
iteyelmp
reviewed
Jul 24, 2026
| // Hash returns the block hash of the header, which is simply the keccak256 hash of its | ||
| // Serialize encoding. | ||
| func (h *RootBlockHeader) Hash() common.Hash { | ||
| //return serHash(*h, map[string]bool{"Signature": true}) |
There was a problem hiding this comment.
The commented-out hash implementation is confusing. Is there any reason to keep this old Signature-excluded version here? If not, could we remove it to avoid ambiguity?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5th PR of QuarkChain/pm#155.