slave (M1): add slave node with config and genesis by syntrust · Pull Request #21 · QuarkChain/goshard

syntrust · 2026-06-23T10:34:20Z

Boot a slave from a pyquarkchain-compatible cluster_config.json. The slave hosts the shards assigned to one slave identity (tracking issue #17).

cmd/slave: config (validate + print a normalized per-slave summary) and genesis (derive the root genesis block, hash byte-identical to pyquarkchain's GenesisManager.create_root_block())
qkc/config: cluster config loader (load.go, incl. ETH_CHAIN_ID consistency check) and checked-in singularity mainnet/devnet configs
qkc/genesis: root-block derivation
qkc/types: root block, token balances, helpers
Makefile: make slave target

Tests passed:

go test ./cmd/slave/...
go test ./qkc/...

Boot a slave from a pyquarkchain-compatible cluster_config.json. The slave hosts the shards assigned to one slave identity and performs no network I/O yet (tracking issue #17). - cmd/slave: `config` (validate + print a normalized per-slave summary) and `genesis` (derive the root genesis block, hash byte-identical to pyquarkchain's GenesisManager.create_root_block()) - qkc/config: cluster config loader (load.go) and checked-in singularity mainnet/devnet configs - qkc/genesis: root-block derivation - qkc/types: root block, token balances, helpers - Makefile: `make slave` target Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

blockchaindevsh · 2026-06-24T05:37:23Z

Looks like both this PR and #20 are adding duplicate content to qkc/types/?

syntrust · 2026-06-25T06:37:24Z

Looks like both this PR and #20 are adding duplicate content to qkc/types/?

All types required to achieve the current milestone. We can use a refactor later before merging into the base.

iteyelmp · 2026-06-25T08:58:24Z

+	app.Flags = slices.Concat(
+		[]cli.Flag{},
+		debug.Flags,
+	)


The expression slices.Concat([]cli.Flag{}, debug.Flags) is unnecessarily complex. Concatenating with an empty slice produces the same result as debug.Flags alone. Simplifying to debug.Flags removes one import ("slices") and makes the intent clearer.

Fixed in f92ba2f

iteyelmp · 2026-06-25T08:59:04Z

+			len(shard.Genesis.Alloc),
+		)
+	}
+	tw.Flush()


The error returned by tw.Flush() is silently ignored.

Ignoring Flush() errors is consistent with surrounding Fprintf calls, both of which write targeting os.Stdout. This is common in geth, so it's acceptable and not a defect.

iteyelmp · 2026-06-25T09:07:57Z

+		if v.Sign() == 0 {
+			continue
+		}
+		t.balances[k.Uint64()] = v


Validate bigint(k) range before converting to uint64 to prevent truncation collisions.

Fixed in 53d3f97

iteyelmp · 2026-06-25T09:13:05Z

+	num, err := bb.GetUInt32()
+	if err != nil {
+		return err
+	}


Should we add an entry count validation here to prevent potential OOM/DoS attacks from malicious data?

Not really. Firstly, make does not pre-allocate according to num; secondly, every time an entry is read, it goes through the getBytes boundary check; plus, forcing an upper limit that pyquarkchain does not have will only create consensus disagreements.

…into slave-m1

pyquarkchain always derives ETH_CHAIN_ID as BASE_ETH_CHAIN_ID + CHAIN_ID + 1 and overwrites any configured value with that derivation on load (config.py:534); accept a configured value only when consistent with it.

pyquarkchain's arithmetic is unbounded, so BASE_ETH_CHAIN_ID + CHAIN_ID + 1 may exceed uint32; the uint32 sum wrapped silently (worst case to 0, which reads as "absent" and passes any configured value).

Adopt the final CLI shape in the milestone that creates these files: newApp assembles the app for tests, the cluster_config/node_id flags register globally without Required (actions validate presence via loadClusterConfig), and only non-networked debug flags are exposed, pinned by TestNoNetworkedDebugFlags. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…stone Drop the milestone markers and the not-yet-implemented tracker, adopt the final fixtures/pyquarkchain cross-validation section (including the virtualenv note in the singularity regeneration command), so later milestones only add sections. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

The pyquarkchain derivation snippet already lives (with seal/serialize output) in qkc/config/singularity/README.md; link to that section instead of carrying a trimmed copy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…into slave-m1

qzhodl · 2026-07-22T10:47:13Z

+	// overwrites any configured value with that derivation (config.py:534), so a
+	// present value is only accepted when consistent (checked in Validate). Zero
+	// means absent: real chain ids start at BASE_ETH_CHAIN_ID + 1 > 0.
+	EthChainID        uint32 `json:"ETH_CHAIN_ID,omitempty"`


ETH_CHAIN_ID is validated but never derived. When omitted (as in both singularity configs), chain and shard configs retain 0, while pyquarkchain sets BASE_ETH_CHAIN_ID + CHAIN_ID + 1. Normalize it before copying ChainConfig into shard configs, and distinguish omission from an explicit zero.

Fixed in fbfca80

qzhodl · 2026-07-22T10:47:36Z

+		return nil, fmt.Errorf("genesis: ROOT.GENESIS.HASH_MERKLE_ROOT: %w", err)
+	}
+
+	difficulty := new(big.Int).SetUint64(g.Difficulty)


RootGenesis.Difficulty is uint64 and Nonce is uint32, but the QKC wire types are biguint and uint64. Valid pyquarkchain configs such as difficulty 2^64 or nonce 2^32 are rejected before hashing. Please preserve the wire ranges and add a Python golden case.

Fixed in fbfca80

qzhodl · 2026-07-22T10:47:38Z

+			if shard.Genesis == nil {
+				return fmt.Errorf("full shard id 0x%08x has no GENESIS", id)
+			}
+			if shard.Genesis.RootHeight != root.Height {


Validate does not check shard-genesis hex fields. For example, EXTRA_DATA: "zz" is silently decoded as empty and slave config reports config OK; the failure is deferred until shard genesis creation. Strictly validate HASH_PREV_MINOR_BLOCK, HASH_MERKLE_ROOT, EXTRA_DATA, and ALLOC code/storage at load time.

Fixed in fbfca80

qzhodl · 2026-07-22T10:47:40Z

+		if slave == nil {
+			continue
+		}
+		if len(slave.ChainMaskListForBackward) > 0 {


len(...) > 0 misses a present but empty CHAIN_MASK_LIST. With CHAIN_MASK_LIST: [] and no FULL_SHARD_ID_LIST, this config passes and reports zero shards. Track field presence and reject the legacy key whenever it is present.

Fixed in fbfca80

qzhodl · 2026-07-22T10:47:41Z

+// TokenBalances maps a token id to a balance. It implements serialize.Serializable
+// so it can be embedded in RootBlockHeader and hashed byte-identically to
+// pyquarkchain's TokenBalanceMap.
+type TokenBalances struct {


TokenBalances depends on the pending PR from Alan. Please sync/rebase this implementation onto the latest TokenBalances code after that PR lands, to avoid maintaining a duplicate or divergent type.

Fixed in fbfca80

ping-ke · 2026-07-24T02:45:27Z

+	}
+	nodeIDFlag = &cli.StringFlag{
+		Name:  "node_id",
+		Usage: "Slave identity (e.g. S0) selecting which shards this process owns",


Should the "Usage" section mention that this node_id needs to match the name of the xxx field in the configuration?

fixed in a31e269

ping-ke · 2026-07-24T02:59:16Z

+
+Both: 8 chains (one shard each), 4 slaves `S0..S3` each owning 2 shards,
+`FULL_SHARD_ID_LIST` form (S0's first id is written `0x1`), genesis `ALLOC` present.
+


Should we add some notes regarding the configuration? For instance:
To expose the service to public, you need to change, "JSON_RPC_HOST" to 0.0.0.0,
as well as the following settings:
PRIVATE_JSON_RPC_HOST
ENABLE_TRANSACTION_HISTORY

Or add configuration files for specific purposes, such as a node with an index.

Not related to this PR. We may expand/update this doc later.

ping-ke · 2026-07-24T03:15:28Z

+	"github.com/ethereum/go-ethereum/common"
+	"github.com/ethereum/go-ethereum/qkc/account"
+)
+


This file is included in this minimal version rootblock to ensure the PR is self-contained; since more content will need to be added later, it would be best to include a TODO comment explaining this.

fixed in a31e269

ping-ke · 2026-07-24T03:24:39Z

+// mixhash, and signature are all empty/zero, exactly as the Python default header.
+// The resulting header.Hash() is byte-identical to pyquarkchain's
+// create_root_block().header.get_hash().
+func RootBlock(qkc *config.QuarkChainConfig) (*types.RootBlockHeader, error) {


RootBlock -> CreateRootBlock ?

fixed in a31e269

ping-ke · 2026-07-24T03:25:54Z

@@ -0,0 +1,79 @@
+// Copyright 2026-2027, QuarkChain.


Why are we moving it here?

What are you referring to?

Its previous path is core/genesis.go, should we put it qkc/core/genesis.go?

Fixed in 38d5c80

ping-ke · 2026-07-28T02:30:36Z

@@ -0,0 +1,79 @@
+// Copyright 2026-2027, QuarkChain.


Its previous path is core/genesis.go, should we put it qkc/core/genesis.go?

…into slave-m1

syntrust requested review from blockchaindevsh, iteyelmp, ping-ke, qizhou and qzhodl June 24, 2026 02:32

syntrust marked this pull request as ready for review June 24, 2026 02:33

syntrust changed the title ~~slave: add slave node (M1) with config and genesis~~ slave (M1): add slave node with config and genesis Jun 24, 2026

iteyelmp reviewed Jun 25, 2026

View reviewed changes

syntrust mentioned this pull request Jun 26, 2026

QKC/OP Devs Meeting #100 QuarkChain/pm#150

Closed

syntrust added 2 commits June 26, 2026 15:02

fix comment

f92ba2f

fix comment

53d3f97

syntrust requested a review from iteyelmp July 3, 2026 03:14

Merge branch 'goshard/base' of https://github.com/QuarkChain/goshard …

72238f2

…into slave-m1

This was referenced Jul 3, 2026

QKC/OP Devs Meeting #101 QuarkChain/pm#152

Closed

slave (M2): stand each shard at its real QKC minor genesis block #26

Open

EthStorage Devs Meeting #184 Agenda ethstorage/pm#266

Closed

ping-ke reviewed Jul 8, 2026

View reviewed changes

Comment thread qkc/types/tokenbalances.go Outdated

Comment thread qkc/types/tokenbalances.go Outdated

syntrust mentioned this pull request Jul 14, 2026

EthStorage Devs Meeting #185 Agenda ethstorage/pm#267

Closed

syntrust and others added 5 commits July 14, 2026 16:25

qkc/config: parse and validate per-chain ETH_CHAIN_ID

9b92428

pyquarkchain always derives ETH_CHAIN_ID as BASE_ETH_CHAIN_ID + CHAIN_ID + 1 and overwrites any configured value with that derivation on load (config.py:534); accept a configured value only when consistent with it.

qkc/config: compute the ETH_CHAIN_ID derivation in uint64

81c1654

pyquarkchain's arithmetic is unbounded, so BASE_ETH_CHAIN_ID + CHAIN_ID + 1 may exceed uint32; the uint32 sum wrapped silently (worst case to 0, which reads as "absent" and passes any configured value).

syntrust requested review from ping-ke July 17, 2026 03:20

syntrust mentioned this pull request Jul 17, 2026

QKC/OP Devs Meeting #103 QuarkChain/pm#158

Closed

Merge branch 'goshard/base' of https://github.com/QuarkChain/goshard …

67ede3a

…into slave-m1

qzhodl reviewed Jul 22, 2026

View reviewed changes

syntrust added 2 commits July 23, 2026 14:45

merge

c0b4751

fix comments

fbfca80

syntrust requested a review from qzhodl July 23, 2026 08:35

qzhodl approved these changes Jul 23, 2026

View reviewed changes

qzhodl mentioned this pull request Jul 24, 2026

QKC/OP Devs Meeting #104 QuarkChain/pm#159

Closed

ping-ke reviewed Jul 24, 2026

View reviewed changes

fix comments

a31e269

ping-ke approved these changes Jul 28, 2026

View reviewed changes

syntrust added 2 commits July 28, 2026 10:35

Merge branch 'goshard/base' of https://github.com/QuarkChain/goshard …

b6db6a7

…into slave-m1

fix build

4a04462

ping-ke mentioned this pull request Jul 28, 2026

EthStorage Devs Meeting #187 Agenda ethstorage/pm#269

Closed

fix comments

38d5c80

syntrust merged commit 7ca760f into goshard/base Jul 28, 2026


		Both: 8 chains (one shard each), 4 slaves `S0..S3` each owning 2 shards,
		`FULL_SHARD_ID_LIST` form (S0's first id is written `0x1`), genesis `ALLOC` present.

Uh oh!

Conversation

syntrust commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blockchaindevsh commented Jun 24, 2026

Uh oh!

syntrust commented Jun 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ping-ke Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ping-ke Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

syntrust commented Jun 23, 2026 •

edited

Loading

ping-ke Jul 28, 2026 •

edited

Loading

ping-ke Jul 28, 2026 •

edited

Loading