Conversation
Member
|
Thanks for setting this up! Would be cool if the tests actually pass, but since this is not really relevant for what this PR is trying to achieve I would then still merge anyways. |
lkdvos
previously approved these changes
May 11, 2026
Member
Author
|
AMD CI is really backed up but we can just see what happens when it finally clears, I guess |
Member
|
Ah, it turns out we need proper overloads for the allocator as well. I give this a quick try but I don't have access to any AMD machines so I can't actually try this out. |
Member
Author
|
I do have access so I'll give it a whirl tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.