Update Asset Index to be BigInt - #4
Open
PJvGrol wants to merge 11 commits into
Open
Conversation
Updated the Algorand .NET SDK version from 0.2.2.0-beta14 to 0.2.2.0-beta15 to incorporate the latest features and bug fixes.
Updated the Algorand .NET SDK version from 0.2.2.0-beta15 to 0.2.2.0-beta16 to incorporate the latest features and bug fixes.
Changed the parameter type for `asset_id` from `int?` to `ulong?` in the `AccountsAsync` and `TransactionsAsync` methods within the `SearchApi.cs` file, affecting both overloads of each method in the `Algorand.V2.Indexer` namespace.
Updated the Algorand .NET SDK version from 0.2.2.0-beta16 to 0.2.2.0-beta17 to incorporate the latest features and bug fixes.
PJvGrol
commented
Jul 15, 2024
PJvGrol
commented
Jul 15, 2024
| /// <returns>(empty)</returns> | ||
| /// <exception cref="ApiException">A server side error occurred.</exception> | ||
| System.Threading.Tasks.Task<Response> AccountsAsync(int? asset_id, int? limit, string next, ulong? currency_greater_than, bool? include_all, ulong? currency_less_than, string auth_addr, ulong? round, int? application_id); | ||
| System.Threading.Tasks.Task<Response> AccountsAsync(ulong? asset_id, int? limit, string next, ulong? currency_greater_than, bool? include_all, ulong? currency_less_than, string auth_addr, ulong? round, int? application_id); |
Member
Author
There was a problem hiding this comment.
if we're making assetid an ulong here, we should probably do the same on the actual asset model? (instead of bigint)
Removed the automatic generation of `asset.MetadataHash` in the Algorand namespace within Utils.cs. Now, the validation logic only allows a `MetadataHash` that is exactly 32 bytes long and throws an exception for any other length, ensuring that a valid hash must be explicitly provided.
Updated the Algorand .NET SDK version from 0.2.2.0-beta17 to 0.2.2.0-beta18 to incorporate the latest features and bug fixes.
PJvGrol
force-pushed
the
asset-index-bigint
branch
from
October 8, 2024 12:22
3b7c075 to
2e69ccc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.