Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
resolve_rebalance_planis given aPortfolioSnapshotwhose positions use LongBridge/full market symbols such asSOXL.US,build_account_state_from_portfolio_snapshotfilters those positions againstself.strategy_symbolslikeSOXL, so the convertedmarket_valuesare all zero. This new override then replaces the previoussnapshot.total_equitywith cash-only equity, causing strategies that requestaccount_statefrom a broker-symbol snapshot to understate total strategy equity. Strip/normalize the configured suffix before relying on the filteredmarket_values, or compute the sum from symbols matched to the strategy roots.Useful? React with 👍 / 👎.