Emit __delitem__ on IDictionary and IList - #100
Merged
Martin-Molinero merged 1 commit intoSep 3, 2026
Merged
Conversation
Python.NET now supports del obj[key] through IDictionary<K,V>.Remove and IList<T>.RemoveAt. Emit __delitem__ on those two interfaces so implementers inherit it and type checkers stop flagging valid deletes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
jhonabreul
force-pushed
the
feature-delitem-stubs
branch
from
September 2, 2026 15:19
badc432 to
509d422
Compare
Martin-Molinero
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to QuantConnect/pythonnet#149.
Problem
del obj[key]onIDictionary<K,V>andIList<T>implementers.__delitem__anywhere, so type checkers flag valid code:Changes
MethodParser.VisitIndexerDeclaration: emit__delitem__onSystem.Collections.Generic.IDictionaryandIListonly. Implementers inherit it.RendererTests: new golden case for both interfaces plus a plain indexer class that must not get__delitem__.Verification
__delitem__definitions, onIDictionaryandIList.--check-untyped-defs) on the regenerated stubs:Dictionary,ConcurrentDictionary,Listandalgo.securitiesdeletes are clean;BitArrayis still flagged, matching the runtime.Ordering
Publish with or after the pythonnet release containing #149, otherwise the checker goes quiet on code that still crashes.
🤖 Generated with Claude Code