feat(widget): two-step install with a lazy signing secret - #538
Merged
Conversation
Cloud and self-host users were stuck looking for QUACKBACK_WIDGET_SECRET. Mint the secret on first admin fetch, put the launcher first, and keep regenerate on the install page. Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Critic pass: launcher prompt forbids QUACKBACK_WIDGET_SECRET, Show on your website lives on the install page, regenerate writes the new secret into cache, and async confirm stays open until the rotate finishes. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Keep async ConfirmDialog submits single-shot, toast when the site toggle fails, and stop sending detected installs to another settings page. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settings.widget_secretlazily on the admin fetch (not workspace create). Public identify stays read-only.QUACKBACK_WIDGET_SECRETon Quackback. Same path for both.Test plan
wgt_secret appears.Made with Cursor