fix(fleet): include 0278 in the post-0248 replay-gate span - #537
Merged
Conversation
Adding two_factor lockout columns turned the pinned replay set red. 0278 is expand-only; list it so the gate still documents the operator path across the mutating migrations in this span.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The golden ledger counts scanned migrations. 0278 is expand-only so destructive DDL stays at 34; the scan total goes 255 → 256.
Member
Author
|
Pushed the CONTRACT.md snapshot update (scanned 255 → 256; destructive DDL unchanged). That was the remaining CI failure on shard 1/4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0278_two_factor_lockout. The fleet replay-gate test pins the post-0248 span, so CI shardtest (2/4)failed withexpected [ …(30) ] to deeply equal [ …(29) ].0278_two_factor_lockoutto that list. The migration is expand-only; the gate still refuses unattended heals because of 0257/0262/0263.Follow-up to #536 / #432.
Test plan
apps/web/src/lib/server/fleet/__tests__/migrator-gate.test.ts(22 tests)test (2/4)green on this PR before merge