fix(realtime): tear down chat streams inside the request's workspace scope - #503
Merged
Conversation
…scope The abort listener and the SSE cancel hook are invoked by the runtime outside the request's AsyncLocalStorage context, so under pooled tenancy clearPresence ran with no workspace scope and threw on every client disconnect. That left the presence row to expire on its own and, because wentOffline never came back true, skipped requeueUnansweredOnAgentOffline for an agent whose last stream closed. Capture the scope while the request is live and re-enter it for teardown, the same pattern the auth stash sweeps already use. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clearPresencein/api/chat/stream's cleanup threwWorkspaceScopeMissingErroron every client disconnect: the abort listener and SSE cancel hook run outside the request's AsyncLocalStorage context. Logged asclear presence failedon each teardown.wentOfflinenever came back true, sorequeueUnansweredOnAgentOfflinewas skipped when an agent's last stream closed.getWorkspaceScope()while the request is live and run teardown viarunWithWorkspaceScope— the patternauth/index.tsandresolved-claims-stash.tsalready use for their detached sweeps. Single-tenant installs (no scope) are unchanged.Test plan
clearPresenceobserves the scope (fails onmain, passes here)clear presence failedwarnings stop onwebMade with Cursor