Fix applyMultiStateControlledSqrtSwap argument list#737
Fix applyMultiStateControlledSqrtSwap argument list#737D-Exposito wants to merge 4 commits intoQuEST-Kit:develfrom
Conversation
Updates version references and fixes doxygen parsing of CMake configured header broken in QuEST-Kit#616
Remove numControls argument from applyMultiStateControlledSqrtSwap overloaded definition taking std::vector<int>
|
Ah yes, I see the declaration doesn't match the definition at QuEST/quest/src/api/operations.cpp Line 768 in 9d7618d Good catch, thanks! Assuming tests pass, I'll merge into devel as we're only a month out from a new minor release. |
|
Hi @D-Exposito -- in the end I've migrated your commit to a branch based on devel to make my life easier. It looks like I've managed to preserve the authorship record okay, so I'll close this one. Your commit will now be merged in #738! |
|
Wew nice catch! @D-Exposito do you wish to be included in the QuEST patch authors list? If so, please share a name (or we can just use your account handle) to be listed e.g. here. This is a microscopic diff of course, but pixels are free! |
|
Hi @TysonRayJones ! I feel it's quite undeserved, but it would be cool to appear if you offer. My full name is Daniel Expósito Patiño. I'll keep working with QuEST, maybe I will find other ways to contribute :) |
Minimal change to match argument list of
applyMultiStateControlledSqrtSwapon implementation and header files.On the header file,
applyMultiStateControlledSqrtSwaphad an extra argumentnumControlswhich is not needed when takingstd::vector<int>arguments. This difference caused compilation errors.Let me know if a pull request is not the correct protocol for fixing something as small as this.