[ninovanhooff]

Summary

The release workflows never overrode the version code, so every build had version code / build number 1 from gradle.properties, and couldn't be installed over the previous build or uploaded to TestFlight again.

• Android: android-release.yml passed -Papp.versionCodeOverride and -Papp.versionNameOverride, but no build script reads those properties; androidApp and shared read appVersionCode / appVersionName.
• iOS: ios-release.yml passed CURRENT_PROJECT_VERSION from printAppVersionMetadata, which just returned the gradle.properties value.

Changes

• Added a prepare-release composite action (based on the one in widm-android). It sets ORG_GRADLE_PROJECT_appVersionCode to github.run_number plus an optional versioncode_offset. Gradle reads ORG_GRADLE_PROJECT_* environment variables as project properties, which take precedence over gradle.properties. So every later Gradle call in the job gets the same value without changing tracked files, including the embedAndSignAppleFrameworkForXcode call that Xcode starts.
• Both release workflows run the action before "Resolve app version metadata". That covers:
  • the Android APK/AAB versionCode
  • the iOS CURRENT_PROJECT_VERSION
  • BuildKonfig's APP_VERSION_CODE on both platforms
  • artifact names, Firebase release notes and run summaries
• Removed the unused -Papp.*Override flags from the Android workflow.
• The iOS metadata step now logs the resolved version, so it's visible in the run log.

Testing

Ported from Q42/GoingsOn.CMP#53:

• Android: release run Setup proper Dependency Injection (Koin is in the project already, but not used) #12 passed, signed, with artifacts …-v1.0.0-12-release-apk / -aab.
• iOS: release run Setup clean architecture module structure #10 resolved version code: 10 in the metadata step. The run then stopped at "Install code signing certificate" because that repository has no Apple secrets yet, so the archive and TestFlight upload were not exercised.
• BuildKonfig: locally, ORG_GRADLE_PROJECT_appVersionCode=13 ./gradlew :shared:generateBuildKonfig generated APP_VERSION_CODE = 13, and 1 without the variable.

Not yet run on this repository.

🤖 Generated with Claude Code

[Copilot]

🟢 Approval recommended

No active review issues are reported for the Android release-versioning changes.

No open issues 🎉

What changed in this PR

Fixes Android release versioning by writing the workflow run number to appVersionCode in gradle.properties, keeping release artifacts and shared build metadata consistent.

Changes:

• Adds a reusable release-preparation action with an optional version-code offset.
• Runs preparation before resolving Android version metadata.
• Removes unused Gradle version override flags from build and Firebase upload commands.

File	Description
.github/​workflows/​android-release.yml	Prepares the version code before metadata resolution and removes unused overrides.
.github/​actions/​prepare-release/​action.yml	Calculates, writes, and verifies the run-based version code.

_{Review effort: Balanced}

[mbernson]

We have a repository with reusable Actions here: https://github.com/Q42/actions
If this is a GitHub Action that we want to use for every project, it might make sense to put it there, so we can update it in a single place and not have the code duplicated in every project repo.

[ninovanhooff]

So your suggestion is to create an action there called q42/gradle-version-number and update the current PR to use it in the prepare-release action, right? I think I like that idea