Repository navigation
Fix: make implicit viewer state explicit and repair its transition races - #66
Merged
Merged
Conversation
Route native, adapter, HLS and standalone playback through one report/reset path; emit adapter transport events; clear seeking/ended state on pause and replay.
Remove the dead startAt branch and reset a destroyed instance completely.
Invalidate suspended step opens, reset end reporting on a jump restart, report user pause, and stop a replaced tour.
Apply per-image volume, dedupe the unlock probe, retry the playlist on gesture, resume hidden GL videos, clear stale cues, and re-init fullscreen on a target change.
One close path, a cancellable return timer, a re-armed popup latch, and no redundant menu hook flag.
Retry rejected setup, clear switching/error, name tile phases, replace watermarks, and release removed canvas video listeners.
Stop a paused Ani before replacing it, cancel kinetic on a click, and let a wheel tick ignore an active drag/pinch.
Release a dragged page before navigation, resolve old goto waiters immediately, and stop a solver-less frame loop once idle.
Record behind-delayed z tiers, guard delayed fades by set id, respect hidden layouts, hook serial events before the first set, and resume cameras on teardown.
Measure the scrubber fresh, end omni gestures when their origin lifts, own strip flags, reset the mobile sheet, and keep the dial cancel guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch fixes the implicit state-machine hazards found in the viewer audit without introducing a reducer/FSM framework. Each subsystem now has one owner/reset path for the state it mirrors.
Main fixes
goto()waiters settle, paused animations abort.pointercancel.Verification
typecheck,lint, 334 core tests, and 751 targeted browser tests across 37 files all pass. The existingdev.htmlmodification is not included.