feat: add better cleaning mode support by Lash-L · Pull Request #817 · Python-roborock/python-roborock

Lash-L · 2026-04-25T03:35:14Z

Adds a clean mode selector

codecov · 2026-04-25T03:36:05Z

Codecov Report

❌ Patch coverage is 93.49112% with 11 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
roborock/data/v1/v1_clean_modes.py	87.67%	5 Missing and 4 partials ⚠️
tests/devices/traits/v1/test_status.py	97.53%	1 Missing and 1 partial ⚠️

Files with missing lines	Coverage Δ
roborock/devices/traits/v1/status.py	`96.66% <100.00%> (+1.11%)`	⬆️
tests/devices/traits/v1/test_status.py	`98.62% <97.53%> (-1.38%)`	⬇️
roborock/data/v1/v1_clean_modes.py	`85.40% <87.67%> (+2.94%)`	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Adds a high-level “cleaning mode” abstraction for V1 devices (vacuum / vac+mop / mop / custom / smart), including mode classification from status codes and RPC payload generation for setting modes.

Changes:

Introduces CleaningModes plus helpers to compute supported options, classify current mode, and build SET_CLEAN_MOTOR_MODE payloads.
Exposes cleaning-mode options/current mode/name and adds set_cleaning_mode() on StatusTrait.
Adds/extends unit tests for cleaning mode behavior and updates the V1 device snapshot output.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`roborock/data/v1/v1_clean_modes.py`	Adds `CleaningModes` and implements option discovery, payload generation, and current-mode classification.
`roborock/devices/traits/v1/status.py`	Surfaces cleaning-mode APIs on `StatusTrait` (options/current/name/get/set).
`tests/devices/traits/v1/test_status.py`	Adds a focused test suite for cleaning-mode options, classification, and RPC payloads.
`tests/devices/__snapshots__/test_v1_device.ambr`	Updates snapshot to include newly exposed cleaning-mode fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

roborock/data/v1/v1_clean_modes.py:304

is_smart_mode_set() has the same int-vs-enum comparison issue as is_mode_customized(): when water_mode/clean_mode/mop_mode are ints from device status, expressions like water_mode == WaterModes.SMART_MODE will always be False. Compare using .code or reverse operand order (e.g., WaterModes.SMART_MODE == water_mode) so SMART_MODE is correctly detected.

    return (
        water_mode == WaterModes.SMART_MODE
        or clean_mode == VacuumModes.SMART_MODE
        or mop_mode == CleanRoutes.SMART_MODE
    )

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

roborock/data/v1/v1_clean_modes.py:304

is_smart_mode_set() has the same int-vs-RoborockModeEnum comparison issue as is_mode_customized() (e.g., water_mode == WaterModes.SMART_MODE). When callers pass integer codes, these checks will always be False because the int is on the left. Compare against .code values or flip the comparisons so the enum’s __eq__ can handle ints.

    return (
        water_mode == WaterModes.SMART_MODE
        or clean_mode == VacuumModes.SMART_MODE
        or mop_mode == CleanRoutes.SMART_MODE
    )

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

allenporter · 2026-04-26T01:49:34Z

    SUPER_DEEP = ("super_deep", 8)


+class CleaningModes(StrEnum):


CleaningMode?

allenporter · 2026-04-26T01:54:12Z

+    return options
+
+
+def get_mop_only_vacuum_mode(features: DeviceFeatures) -> VacuumModes:


This is getting the vaccuum mode when the vacuum is in mop only mode?

allenporter · 2026-04-26T01:55:58Z

+        )
+
+    @property
+    def cleaning_mode_name(self) -> str | None:


Should be current_cleaning_mode_name?

allenporter · 2026-04-26T01:56:41Z

+        return cleaning_mode.value
+
+    def get_cleaning_mode_parameters(self, cleaning_mode: str | CleaningModes) -> list[dict[str, int]]:
+        """Get the RPC payload for the selected high-level cleaning mode."""


I was going to say this can be private, but really I think it can just be inlined. in set_cleaning_mode

allenporter · 2026-04-26T01:58:21Z

    SUPER_DEEP = ("super_deep", 8)


+class CleaningModes(StrEnum):


Some pydoc here describing how this differs from the other lower level modes would be useful. Basically never use those and always use this?

allenporter · 2026-04-26T02:06:12Z

+    return WaterModes.STANDARD.code
+
+
+def _get_clean_motor_mode_params(mode: CleaningModes, features: DeviceFeatures) -> tuple[int, int, int]:


I think this should be using the enum types instead of the code everywhere in this file, then only convert to the code when added to the params dict

allenporter · 2026-04-26T02:08:23Z

+    return [params]
+
+
+def get_current_cleaning_mode(


One thought is that this could be on CleaningModes as a classmethod like CleaningModes.from_modes
or similarlyget_cleaning_mode_parameters can be CleaningModes.get_params(...)

I think the only advantage could be the names would be shorter, but otherwise its not to different than what is here and can just be a style choice (optional)

allenporter · 2026-04-26T02:08:33Z

+
+
+def get_current_cleaning_mode(
+    clean_mode: int | None,


Can this also take the enum values instead of the codes?

allenporter · 2026-04-26T02:12:01Z

+def get_cleaning_mode_parameters(cleaning_mode: str | CleaningModes, features: DeviceFeatures) -> list[dict[str, int]]:
+    """Get the RPC payload for switching the high-level cleaning mode."""
+    try:
+        mode = CleaningModes(cleaning_mode)


i'd say do the string to enum conversation as high up as possible and just take the enum here

feat: add better cleaning mode support

35e7354

Lash-L requested a review from Copilot April 25, 2026 03:35

Copilot started reviewing on behalf of Lash-L April 25, 2026 03:35 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread roborock/data/v1/v1_clean_modes.py Outdated

Comment thread tests/devices/traits/v1/test_status.py

chore: address comments from copilot

c29c38f

Lash-L requested a review from Copilot April 25, 2026 13:25

Copilot started reviewing on behalf of Lash-L April 25, 2026 13:25 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread roborock/data/v1/v1_clean_modes.py Outdated

Comment thread roborock/devices/traits/v1/status.py Outdated

Comment thread tests/devices/traits/v1/test_status.py

chore: address comments from copilot

8bb33cc

Lash-L requested a review from Copilot April 25, 2026 14:30

Copilot started reviewing on behalf of Lash-L April 25, 2026 14:31 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread roborock/data/v1/v1_clean_modes.py

Comment thread tests/devices/traits/v1/test_status.py Outdated

chore: address comments from copilot

68797de

Lash-L requested a review from Copilot April 25, 2026 15:28

Copilot started reviewing on behalf of Lash-L April 25, 2026 15:29 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Lash-L requested a review from allenporter April 25, 2026 15:54

allenporter requested changes Apr 26, 2026

View reviewed changes

		return options


		def get_mop_only_vacuum_mode(features: DeviceFeatures) -> VacuumModes:

		return WaterModes.STANDARD.code


		def _get_clean_motor_mode_params(mode: CleaningModes, features: DeviceFeatures) -> tuple[int, int, int]:

Conversation

Lash-L commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lash-L commented Apr 25, 2026 •

edited

Loading

codecov Bot commented Apr 25, 2026 •

edited

Loading