Skip to content

fix: allow protobuf 7.x #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lash-L merged 1 commit into from
Apr 22, 2026
+1 −1
Merged

fix: allow protobuf 7.x #815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies = [
"pycryptodomex~=3.18 ; sys_platform == 'darwin'",
"paho-mqtt>=1.6.1,<3.0.0",
"construct>=2.10.57,<3",
"protobuf>=6.31.1,<7",
"protobuf>=6.31.1,<8",
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checked-in generated module roborock/map/proto/b01_scmap_pb2.py was generated with Protobuf Python 6.31.1 and calls google.protobuf.runtime_version.ValidateProtobufRuntimeVersion(…, 6, 31, 1, …) at import time. Widening the runtime constraint to <8 may allow protobuf 7.x installs that fail at import time if the runtime version validator rejects major-version mismatches. Please verify protobuf 7.x compatibility end-to-end; if it fails, regenerate the pb2 with a protobuf 7.x compiler (or otherwise align/remove the runtime version check) and adjust the constraint accordingly.

Suggested change
"protobuf>=6.31.1,<8",
"protobuf>=6.31.1,<7",

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change claims protobuf 7.x compatibility but CI/tests currently run against whatever is pinned in uv.lock (likely protobuf 6.x). Consider adding a test/CI run that explicitly installs protobuf 7.x (e.g., a matrix entry or an override) to ensure the generated pb2 module imports and map parsing tests pass under 7.x.

Copilot uses AI. Check for mistakes.
"vacuum-map-parser-roborock",
"pyrate-limiter>=4.0.0,<5",
"aiomqtt>=2.5.0,<3",
Expand Down
Loading