Repository navigation
Conversation
Wind and solar power plants are already included from GEM and MASTR. The option added them again from outdated OPSD data and counted them twice. Closes #232. Also apply extend_by_vres with from_url=True and emit a proper FutureWarning for the deprecated extendby_kwargs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #232.
Why
Wind and solar power plants are already in the default output: GEM is fully included, and MASTR covers Germany.
pm.powerplants(extend_by_vres=True)added them again from outdated OPSD data (2020) and counted them twice. As agreed in #232, the option goes; wind and solar stay included.Changes
pm.powerplants(extend_by_vres=True)emits aFutureWarning.extend_by_VRE()(anddf.powerplant.extend_by_VRE()) is marked with@deprecated(deprecated_in="0.10.0", removed_in="0.11.0").from_url=Truesilently ignoredextend_by_vres; it now applies it like the other code paths.extendby_kwargscalledlogger.warning(DeprecationWarning, ...), which failed inside logging. It now emits aFutureWarning.