Feature/new metaid in json2 serializer#197
Merged
JohannesFinsveen merged 8 commits intomainfrom Apr 24, 2026
Merged
Conversation
JohannesFinsveen
requested review from
MikaelNordberg,
likp,
oyessb and
runejo
as code owners
likp
previously approved these changes
Apr 24, 2026
runejo
reviewed
Apr 24, 2026
Member
runejo
left a comment
runejo
left a comment
There was a problem hiding this comment.
@JohannesFinsveen
Consider https://www.conventionalcommits.org/en/v1.0.0/ when creating PR title
Compare the files in this serializer with the corresponding files in PxWebApi and try to minimize the difference
PCAxis.Serializers/JsonStat2/Model/JsonStat2Dataset.cs
PxWebApi/PxWeb/Models/Api2/DatasetSubclass.cs
PCAxis.Serializers/JsonStat2Serializer.cs
PxWebApi/PxWeb/Mappers/DatasetMapper.cs
…ub.com/PxTools/PCAxis.Serializers into feature/new-metaid-in-json2-serializer
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumbs PxWeb.Api2.Server.Models to version "2.3.2" as a sideeffect
In the same way as the metadata endpoint, the data endpoint now outputs links generated from metaid.
Support for the OldWay of just outputting the urns, will hopfully be dropped in 3.0, so the NewWay does not reuse things like collection of urns from the OldWay.