Verify Menzoberranzan - #742
Open
tomojira wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying Menzoberranzan (1994) (DreamForge Intertainment)
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
The config file isn't needed in the DOSZ. It can be created by
SOUND.BAT.Have any official patches been applied, if necessary?
Yes, v1.1 was already applied.
Is the game data in the root of the ZIP (unless game does not work that way)?
Yes.
For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Yes, I changed to the smaller install size. I didn't notice any difference at the beginning.
Is the entry in the right variant file (i.e. Freeware)?
Yes.
Have digital versions (Steam, GOG) been checked for matching?
Yes, a GOG variant was supposed to be added according to the original PR, but only the DOSC was present. The actual dat was missing, so I added it.
It cannot match with the main variant because of its included CD image.
Can the game benefit from using embedded data or embedded patches in the datfile?
I added embedded data to
INFO.DATto help large install sizes match, as well as a TDC entry (though it still needs the CD of course).Can DoDAT build the game from the install media?
No, files are extracted from containers during initial installation as well as patch installation.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.
Do the file timestamps match the installation media?
No, I added them.
Does the DOSZ run standalone?
Yes.
For CD games, can the game be set up to run without a CD mounted?
No. I found some instructions for a no-CD setup, but it didn't work, it gives a black screen when trying to create characters.
https://www.vogons.org/viewtopic.php?p=50111#p50111
The TDC entry also uses this setup, without a CD included.
Can the game benefit from using CHDtoOGG?
There are no audio tracks.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.
Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Does the DOSC have copy protection removed, if possible?
Unknown if this version has copy protection. Nothing appears at the beginning.
Is the game running at the correct speed? Is CPU year specified?
cpu_year: 1994was set, but I changed tocpu_max_yearbecause it's dynamic.Increasing the year has no effect on the low framerate of the game (around 10 FPS).
Is the DOSC auto-running and skipping past any obstructions? Is it updated to use WAITMODECHANGE if possible?
Yes.
Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
No.
Does the game have General MIDI support?
Yes, but it was missing, I added it.
Is the game set up to run with the best quality graphics options by default?
Not applicable.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
Yes, I enabled it.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Summary of changes
INFO.DATcpu_max_year