Stdlib: array_values() native LLVM JIT/AOT#231
Merged
Conversation
Add native LLVM paths for array_values() on native and hashtable arrays, with compliance and AOT specs. Fix missing terminators in in_array and array copy LLVM helpers that blocked verification. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
array_values()for LLVM JIT and AOT on packed list arrays (native fixed arrays and dynamic hashtables).in_array()andcopyInto()helpers (reduces JIT verify failures).Test plan
bash script/docker-ci.sh— non-LLVM suite passes (236 tests)array_values.phptarray_values.phptcompiles and runs with expected outputdocs/capabilities.mdupdated (array_values: VM/JIT/AOT yes)Made with Cursor