Stdlib: native number_format() for VM and LLVM JIT#227
Merged
Conversation
Implement VmNumberFormat and JitNumberFormat without calling PHP's number_format(), register fabs for LLVM, add compliance/AOT specs, and fix in_array JIT loop indexing plus merge-block terminators in array helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep native VM formatting via VmNumberFormat while using master's __compiler_number_format JIT/AOT runtime and in_array loop fixes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
number_format()from the ground up inVmNumberFormat(VM) andJitNumberFormat(LLVM viasnprintf+ thousands grouping), replacing the previous VM wrapper around PHP'snumber_format().number_format_jit.phpt) and AOT fixture; update capability matrix.in_array()JIT loop to advance the index on non-match and add proper merge-block terminators for array builtin LLVM helpers (reduces JIT test failures vs master).Test plan
./script/docker-ci.sh --exclude-group llvm(231 tests pass)number_format(1234.5, 2)→1,234.50Made with Cursor